From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swbzw-0004HP-8e for qemu-devel@nongnu.org; Wed, 01 Aug 2012 12:42:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swbzv-0004s2-1J for qemu-devel@nongnu.org; Wed, 01 Aug 2012 12:42:12 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:53521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swbzu-0004rt-Ta for qemu-devel@nongnu.org; Wed, 01 Aug 2012 12:42:10 -0400 Received: by ghrr14 with SMTP id r14so7252103ghr.4 for ; Wed, 01 Aug 2012 09:42:10 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 1 Aug 2012 18:41:43 +0200 Message-Id: <1343839312-24030-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343839312-24030-1-git-send-email-pbonzini@redhat.com> References: <1343839312-24030-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: yang.z.zhang@intel.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com From: Yang Zhang Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is used for those registers. Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 3777f85..6e5b2f0 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -220,15 +220,7 @@ static void cmos_ioport_write(void *opaque, uint32_t addr, uint32_t data) rtc_set_time(s); } } - if (((s->cmos_data[RTC_REG_B] ^ data) & (REG_B_DM | REG_B_24H)) && - !(data & REG_B_SET)) { - /* If the time format has changed and not in set mode, - update the registers immediately. */ - s->cmos_data[RTC_REG_B] = data; - rtc_copy_date(s); - } else { - s->cmos_data[RTC_REG_B] = data; - } + s->cmos_data[RTC_REG_B] = data; rtc_timer_update(s, qemu_get_clock_ns(rtc_clock)); break; case RTC_REG_C: -- 1.7.10.4