[Qemu-devel] [PATCH 1/2] qom: add missing 'const' in documentation sample

[Qemu-devel] [PATCH 1/2] qom: add missing 'const' in documentation sample

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 include/qemu/object.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/qemu/object.h b/include/qemu/object.h
index 8b17776..e0d326f 100644
--- a/include/qemu/object.h
+++ b/include/qemu/object.h
@@ -65,7 +65,7 @@ typedef struct InterfaceInfo InterfaceInfo;
  *     int reg0, reg1, reg2;
  * } MyDevice;
  *
- * static TypeInfo my_device_info = {
+ * static const TypeInfo my_device_info = {
  *     .name = TYPE_MY_DEVICE,
  *     .parent = TYPE_DEVICE,
  *     .instance_size = sizeof(MyDevice),
-- 
1.7.10.4

[Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index c6422ad..4b00889 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -816,7 +816,7 @@ static void sysbus_esp_class_init(ObjectClass *klass, void *data)
     dc->vmsd = &vmstate_sysbus_esp_scsi;
 }
 
-static TypeInfo sysbus_esp_info = {
+static const TypeInfo sysbus_esp_info = {
     .name          = "esp",
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(SysBusESPState),
@@ -1178,7 +1178,7 @@ static void esp_pci_class_init(ObjectClass *klass, void *data)
     dc->vmsd = &vmstate_esp_pci_scsi;
 }
 
-static TypeInfo esp_pci_info = {
+static const TypeInfo esp_pci_info = {
     .name = "am53c974",
     .parent = TYPE_PCI_DEVICE,
     .instance_size = sizeof(PCIESPState),
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH 1/2] qom: add missing 'const' in documentation sample

[Andreas Färber]

Am 02.08.2012 10:40, schrieb Hervé Poussineau:
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Acked-by: Andreas Färber <afaerber@suse.de>

/-F

> ---
>  include/qemu/object.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/qemu/object.h b/include/qemu/object.h
> index 8b17776..e0d326f 100644
> --- a/include/qemu/object.h
> +++ b/include/qemu/object.h
> @@ -65,7 +65,7 @@ typedef struct InterfaceInfo InterfaceInfo;
>   *     int reg0, reg1, reg2;
>   * } MyDevice;
>   *
> - * static TypeInfo my_device_info = {
> + * static const TypeInfo my_device_info = {
>   *     .name = TYPE_MY_DEVICE,
>   *     .parent = TYPE_DEVICE,
>   *     .instance_size = sizeof(MyDevice),

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

[Andreas Färber]

Am 02.08.2012 10:40, schrieb Hervé Poussineau:
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

> ---
>  hw/esp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/esp.c b/hw/esp.c
> index c6422ad..4b00889 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -816,7 +816,7 @@ static void sysbus_esp_class_init(ObjectClass *klass, void *data)
>      dc->vmsd = &vmstate_sysbus_esp_scsi;
>  }
>  
> -static TypeInfo sysbus_esp_info = {
> +static const TypeInfo sysbus_esp_info = {
>      .name          = "esp",
>      .parent        = TYPE_SYS_BUS_DEVICE,
>      .instance_size = sizeof(SysBusESPState),
> @@ -1178,7 +1178,7 @@ static void esp_pci_class_init(ObjectClass *klass, void *data)
>      dc->vmsd = &vmstate_esp_pci_scsi;
>  }
>  
> -static TypeInfo esp_pci_info = {
> +static const TypeInfo esp_pci_info = {
>      .name = "am53c974",
>      .parent = TYPE_PCI_DEVICE,
>      .instance_size = sizeof(PCIESPState),
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

[Paolo Bonzini]

Il 02/08/2012 10:40, Hervé Poussineau ha scritto:
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/esp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/esp.c b/hw/esp.c
> index c6422ad..4b00889 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -816,7 +816,7 @@ static void sysbus_esp_class_init(ObjectClass *klass, void *data)
>      dc->vmsd = &vmstate_sysbus_esp_scsi;
>  }
>  
> -static TypeInfo sysbus_esp_info = {
> +static const TypeInfo sysbus_esp_info = {
>      .name          = "esp",
>      .parent        = TYPE_SYS_BUS_DEVICE,
>      .instance_size = sizeof(SysBusESPState),
> @@ -1178,7 +1178,7 @@ static void esp_pci_class_init(ObjectClass *klass, void *data)
>      dc->vmsd = &vmstate_esp_pci_scsi;
>  }
>  
> -static TypeInfo esp_pci_info = {
> +static const TypeInfo esp_pci_info = {
>      .name = "am53c974",
>      .parent = TYPE_PCI_DEVICE,
>      .instance_size = sizeof(PCIESPState),
> 

Applied to scsi-next branch.

Paolo