From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com,
stefanha@linux.vnet.ibm.com, "Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [RFC 04/12] qorum: Add qorum_open().
Date: Thu, 2 Aug 2012 12:16:36 +0200 [thread overview]
Message-ID: <1343902604-13981-5-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1343902604-13981-1-git-send-email-benoit@irqsave.net>
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
block/qorum.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/block/qorum.c b/block/qorum.c
index ea2a720..bdf1530 100644
--- a/block/qorum.c
+++ b/block/qorum.c
@@ -48,11 +48,73 @@ struct QorumAIOCB {
int vote_ret;
};
+/* Valid qorum filenames look like
+ * qorum:path/to/a_image:path/to/b_image:path/to/c_image
+ */
+static int qorum_open(BlockDriverState *bs, const char *filename, int flags)
+{
+ BDRVQorumState *s = bs->opaque;
+ int ret, i;
+ char *a, *b, *c, *filenames[3];
+
+ /* Parse the qorum: prefix */
+ if (strncmp(filename, "qorum:", strlen("qorum:"))) {
+ return -EINVAL;
+ }
+ a = g_strdup(filename + strlen("qorum:"));
+
+ /* Find separators */
+ b = strchr(a, ':');
+ if (b == NULL) {
+ return -EINVAL;
+ }
+
+ c = strrchr(a, ':');
+ if (c == NULL) {
+ return -EINVAL;
+ }
+
+ /* Check that filename contains two separate ':' */
+ if (b == c) {
+ return -EINVAL;
+ }
+
+ /* Split string */
+ *b = '\0';
+ *c = '\0';
+
+ filenames[0] = a;
+ filenames[1] = b + 1;
+ filenames[2] = c + 1;
+
+ /* Open files */
+ for (i = 0; i <= 2; i++) {
+ s->bs[i] = bdrv_new("");
+ ret = bdrv_open(s->bs[i], filenames[i], flags, NULL);
+ if (ret < 0) {
+ goto error_exit;
+ }
+ }
+
+ goto clean_exit;
+
+error_exit:
+ for (; i >= 0; i--) {
+ bdrv_delete(s->bs[i]);
+ s->bs[i] = NULL;
+ }
+clean_exit:
+ g_free(a);
+ return ret;
+}
+
static BlockDriver bdrv_qorum = {
.format_name = "qorum",
.protocol_name = "qorum",
.instance_size = sizeof(BDRVQorumState),
+
+ .bdrv_file_open = qorum_open,
};
static void bdrv_qorum_init(void)
--
1.7.9.5
next prev parent reply other threads:[~2012-08-02 10:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 10:16 [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file Benoît Canet
2012-08-02 14:04 ` Eric Blake
2012-08-02 14:55 ` Benoît Canet
2012-08-02 16:07 ` Andreas Färber
2012-08-02 16:47 ` Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 02/12] qorum: Add QorumSingleAIOCB and QorumAIOCB Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 03/12] qorum: Create BDRVQorumState and BlkDriver and do init Benoît Canet
2012-08-02 10:16 ` Benoît Canet [this message]
2012-08-02 10:16 ` [Qemu-devel] [RFC 05/12] qorum: Add qorum_close() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 06/12] qorum: Add qorum_getlength() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 07/12] qorum: Add qorum_aio_writev and its dependencies Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 08/12] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 09/12] qorum: Add qorum_co_flush() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 10/12] qorum: Add qorum_aio_readv Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 11/12] qorum: Add qorum mechanism Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 12/12] qorum: build feature into QEMU Benoît Canet
2012-08-02 16:06 ` Andreas Färber
2012-08-02 13:17 ` [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency Eric Blake
2012-08-02 13:28 ` Benoît Canet
2012-08-02 18:14 ` Anthony Liguori
2012-08-02 19:22 ` Benoît Canet
2012-08-03 9:21 ` Stefan Hajnoczi
2012-08-03 16:14 ` Blue Swirl
2012-08-03 19:11 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343902604-13981-5-git-send-email-benoit@irqsave.net \
--to=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).