From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwyPB-000355-85 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwyPA-0005UT-1j for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:37:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwyP9-0005UP-Pv for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:37:43 -0400 Message-ID: <1343925460.8003.19.camel@ul30vt> From: Alex Williamson Date: Thu, 02 Aug 2012 10:37:40 -0600 In-Reply-To: <501A4240.8050602@web.de> References: <20120801050241.22163.78549.stgit@bling.home> <20120801051807.22163.96305.stgit@bling.home> <5018D713.1050304@web.de> <1343844589.6698.3.camel@bling.home> <501A4240.8050602@web.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aik@ozlabs.ru, aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Thu, 2012-08-02 at 11:02 +0200, Jan Kiszka wrote: > On 2012-08-01 20:09, Alex Williamson wrote: > > On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: > >> On 2012-08-01 07:18, Alex Williamson wrote: > > > >>> +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE + 14) > >>> + > >>> +#endif /* VFIO_H */ > >>> > >> > >> Please patch update-linux-headers.sh and let it do its work instead > >> (separate patches). > > > > Unfortunately I missed updating the Kbuild file in the kernel, so vfio.h > > doesn't get installed yet. I'll include that in my next pull request, > > but maybe in the meantime I should temporarily put this header back in > > hw/ unless you have a better idea. Thanks, > > Well, if it's going to be fixed very soon, we can merge it like this. > But you should already be able provide a patch for the update script so > that the next one running it against a fixed kernel will not > accidentally drop the vfio header again. What's the reason for the rm -fr; mkdir -p in the update script? I don't see how we'd be unintentionally generating cruft in these directories if we were to just overwrite files instead of removing the directory and repopulating it. I'll get the kernel fixed soon, but I'm tempted to add vfio and drop the expunge of the directory at the same time. Thanks, Alex