qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [RFC 02/19] x86_cpudef_setup: coding style change
Date: Thu,  2 Aug 2012 23:59:09 -0300	[thread overview]
Message-ID: <1343962766-22024-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1343962766-22024-1-git-send-email-ehabkost@redhat.com>

Make source code lines shorter.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9414d75..d546534 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1526,20 +1526,23 @@ void x86_cpudef_setup(void)
     static const char *model_with_versions[] = { "qemu32", "qemu64", "athlon" };
 
     for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) {
-        builtin_x86_defs[i].next = x86_defs;
-        builtin_x86_defs[i].flags = 1;
+        x86_def_t *def = &builtin_x86_defs[i];
+        def->next = x86_defs;
+        def->flags = 1;
 
         /* Look for specific "cpudef" models that */
         /* have the QEMU version in .model_id */
         for (j = 0; j < ARRAY_SIZE(model_with_versions); j++) {
-            if (strcmp(model_with_versions[j], builtin_x86_defs[i].name) == 0) {
-                pstrcpy(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), "QEMU Virtual CPU version ");
-                pstrcat(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), qemu_get_version());
+            if (strcmp(model_with_versions[j], def->name) == 0) {
+                pstrcpy(def->model_id, sizeof(def->model_id),
+                        "QEMU Virtual CPU version ");
+                pstrcat(def->model_id, sizeof(def->model_id),
+                        qemu_get_version());
                 break;
             }
         }
 
-        x86_defs = &builtin_x86_defs[i];
+        x86_defs = def;
     }
 #if !defined(CONFIG_USER_ONLY)
     qemu_opts_foreach(qemu_find_opts("cpudef"), cpudef_register, NULL, 0);
-- 
1.7.11.2

  parent reply	other threads:[~2012-08-03  3:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  2:59 [Qemu-devel] [RFC 00/19] i386 CPU code cleanup + CPU model classes Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 01/19] target-i386/cpu.c: coding style fixes Eduardo Habkost
2012-08-03  2:59 ` Eduardo Habkost [this message]
2012-08-03  2:59 ` [Qemu-devel] [RFC 03/19] i386: x86_def_t: rename 'flags' field Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 04/19] rename cpu_x86_find_by_name to x86_cpu_build_from_name Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 05/19] cpu_x86_build_from_name: use strtok_r() Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 06/19] i386: cpu: extract the full feature list before parsing it Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 07/19] i386: cpu: extract parsing of feature strings to separate function Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 08/19] i386: extract CPU model lookup to a " Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 09/19] i386: reorder object setup on cpu_x86_init() Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 10/19] move CPU object creation to cpu.c Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 11/19] rename x86_def_t to X86CPUDefinition Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 12/19] create struct X86CPUModelTableEntry Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 13/19] move X86CPUDefinition to cpu-qom.h Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 14/19] extract CPU object field initialization from cpu_x86_register() Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 15/19] cpu_x86_create: move error handling to end of function Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 16/19] kill cpu_x86_register() Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 17/19] kill cpu_x86_build_from_name() Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 18/19] register a class for each CPU model Eduardo Habkost
2012-08-03  2:59 ` [Qemu-devel] [RFC 19/19] HACK: late CPU class initialization Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343962766-22024-3-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).