From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sx8DG-0004ml-AJ for qemu-devel@nongnu.org; Thu, 02 Aug 2012 23:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sx8DB-00068D-KZ for qemu-devel@nongnu.org; Thu, 02 Aug 2012 23:06:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sx8DA-000679-Sh for qemu-devel@nongnu.org; Thu, 02 Aug 2012 23:06:01 -0400 From: Eduardo Habkost Date: Thu, 2 Aug 2012 23:59:10 -0300 Message-Id: <1343962766-22024-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1343962766-22024-1-git-send-email-ehabkost@redhat.com> References: <1343962766-22024-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 03/19] i386: x86_def_t: rename 'flags' field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= The field is being used for a single purpose: to indicate if the CPU model is a builtin one. So, instead of an opaque and confusing 'flags' field name, use a boolean 'is_builtin' field to indicate if the model is a built-in one. No behavior change, just a field rename. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index d546534..1154a34 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -236,7 +236,7 @@ typedef struct x86_def_t { uint32_t xlevel; char model_id[48]; int vendor_override; - uint32_t flags; + bool is_builtin; /* Store the results of Centaur's CPUID instructions */ uint32_t ext4_features; uint32_t xlevel2; @@ -1309,7 +1309,7 @@ void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf, const char *optarg) return; } for (def = x86_defs; def; def = def->next) { - snprintf(buf, sizeof(buf), def->flags ? "[%s]" : "%s", def->name); + snprintf(buf, sizeof(buf), def->is_builtin ? "[%s]" : "%s", def->name); if (model || dump) { (*cpu_fprintf)(f, "x86 %16s %-48s\n", buf, def->model_id); } else { @@ -1528,7 +1528,7 @@ void x86_cpudef_setup(void) for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) { x86_def_t *def = &builtin_x86_defs[i]; def->next = x86_defs; - def->flags = 1; + def->is_builtin = true; /* Look for specific "cpudef" models that */ /* have the QEMU version in .model_id */ -- 1.7.11.2