qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Subject: [Qemu-devel] [PATCH 01/10] SCSI: Update the sense code for PREVENT REMOVAL errors
Date: Fri,  3 Aug 2012 10:06:11 +0200	[thread overview]
Message-ID: <1343981180-23817-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1343981180-23817-1-git-send-email-pbonzini@redhat.com>

From: Ronnie Sahlberg <ronniesahlberg@gmail.com>

Change the sense codes for failures to eject a device that is locked
by PREVENT_ALLOW_MEDIUM_REMOVAL from
the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
MEDIUM_REMOVAL_PREVENTED.

The second sense code is more accurate, and is also listed in MMC annex F
for the recommended sense codes for MMC devices while the first sense code is not.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-bus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index e4ec19e..68049f6 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1103,7 +1103,7 @@ const struct SCSISense sense_code_NO_MEDIUM = {
 
 /* LUN not ready, medium removal prevented */
 const struct SCSISense sense_code_NOT_READY_REMOVAL_PREVENTED = {
-    .key = NOT_READY, .asc = 0x53, .ascq = 0x00
+    .key = NOT_READY, .asc = 0x53, .ascq = 0x02
 };
 
 /* Hardware error, internal target failure */
@@ -1153,7 +1153,7 @@ const struct SCSISense sense_code_INCOMPATIBLE_FORMAT = {
 
 /* Illegal request, medium removal prevented */
 const struct SCSISense sense_code_ILLEGAL_REQ_REMOVAL_PREVENTED = {
-    .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x00
+    .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x02
 };
 
 /* Command aborted, I/O process terminated */
-- 
1.7.10.4

  reply	other threads:[~2012-08-03  8:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  8:06 [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03 Paolo Bonzini
2012-08-03  8:06 ` Paolo Bonzini [this message]
2012-08-03  8:06 ` [Qemu-devel] [PATCH 02/10] SCSI: STARTSTOPUNIT only eject/load media if powercondition is 0 Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 03/10] megasas: Update function megasys_scsi_uninit Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 04/10] scsi-disk: fix compilation with DEBUG_SCSI Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 05/10] megasas: static SAS addresses Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 06/10] Revert "megasas: disable due to build breakage" Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 07/10] esp: enable for all PCI machines Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 08/10] esp: add missing const on TypeInfo structures Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 09/10] esp: add Tekram DC-390 emulation (PC SCSI adapter) Paolo Bonzini
2012-08-03  8:06 ` [Qemu-devel] [PATCH 10/10] scsi: add support for ATA_PASSTHROUGH_xx scsi command Paolo Bonzini
2012-08-03 19:27 ` [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03 Anthony Liguori
2012-08-03 19:56   ` Paolo Bonzini
2012-08-03 20:04     ` Anthony Liguori
2012-08-03 20:14     ` Hervé Poussineau
2012-08-03 20:37       ` Anthony Liguori
2012-08-03 20:59         ` Blue Swirl
2012-08-03 21:43     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343981180-23817-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).