qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 7/7] exec.c: Remove out of date comment
Date: Fri,  3 Aug 2012 11:51:06 +0100	[thread overview]
Message-ID: <1343991066-9814-8-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343991066-9814-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Peter Maydell <peter.maydell@linaro.org>

Remove an out of date comment: this comment used to be attached to
cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally
inserted a couple of other functions between the comment and its function.
It is in any case obsolete since (a) the function arguments it refers
to have been replaced with a single MemoryRegionSection* argument and
(b) the inability to handle regions whose offset_within_address_space
and offset_within_region aren't equally aligned was fixed as part of
the rewrite of this code.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 exec.c |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/exec.c b/exec.c
index e6ac3e7..a42a0b5 100644
--- a/exec.c
+++ b/exec.c
@@ -2240,14 +2240,6 @@ static void phys_sections_clear(void)
     phys_sections_nb = 0;
 }
 
-/* register physical memory.
-   For RAM, 'size' must be a multiple of the target page size.
-   If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an
-   io memory page.  The address used when calling the IO function is
-   the offset from the start of the region, plus region_offset.  Both
-   start_addr and region_offset are rounded down to a page boundary
-   before calculating this offset.  This should not be a problem unless
-   the low bits of start_addr and region_offset differ.  */
 static void register_subpage(MemoryRegionSection *section)
 {
     subpage_t *subpage;
-- 
1.7.10.4

  parent reply	other threads:[~2012-08-03 10:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 10:50 [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012 Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 1/7] usb: Clean common object and dependency files Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 2/7] qom: Clean libuser " Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 3/7] remove unused include of error.h Stefan Hajnoczi
2012-08-03 13:00   ` Luiz Capitulino
2012-08-03 13:24     ` Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 4/7] socket: clean up redundant assignment Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 5/7] exec.c: Fix off-by-one error in register_subpage Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 6/7] exec.c: Use subpages for large unaligned mappings Stefan Hajnoczi
2012-08-03 10:51 ` Stefan Hajnoczi [this message]
2012-08-03 13:27 ` [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012 Stefan Hajnoczi
2012-08-03 20:43   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343991066-9814-8-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).