From: Li Zhang <zhlcindy@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: aliguori@us.ibm.com, agraf@suse.de,
Li Zhang <zhlcindy@linux.vnet.ibm.com>,
afaerber@suse.de, david@gibson.dropbear.id.au
Subject: [Qemu-devel] [Qemu-ppc][PATCH v6 3/5] Add one new file vga-pci.h
Date: Sat, 4 Aug 2012 20:05:55 +0800 [thread overview]
Message-ID: <1344081957-4717-4-git-send-email-zhlcindy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1344081957-4717-1-git-send-email-zhlcindy@linux.vnet.ibm.com>
Functions pci_vga_init() and pci_cirrus_vga_init() are declared
in pc.h. That prevents other platforms (e.g. sPAPR) to use them.
This patch is to create one new file vga-pci.h and move the
declarations to vga-pci.h, so that they can be shared by
all the platforms.
Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
---
hw/cirrus_vga.c | 2 +-
hw/pc.h | 4 ----
hw/vga-pci.c | 2 +-
hw/vga-pci.h | 12 ++++++++++++
4 files changed, 14 insertions(+), 6 deletions(-)
create mode 100644 hw/vga-pci.h
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 623dd68..e8dcc6b 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -27,8 +27,8 @@
* available at http://home.worldonline.dk/~finth/
*/
#include "hw.h"
-#include "pc.h"
#include "pci.h"
+#include "vga-pci.h"
#include "console.h"
#include "vga_int.h"
#include "loader.h"
diff --git a/hw/pc.h b/hw/pc.h
index 31ccb6f..e4db071 100644
--- a/hw/pc.h
+++ b/hw/pc.h
@@ -189,14 +189,10 @@ static inline DeviceState *isa_vga_init(ISABus *bus)
return &dev->qdev;
}
-DeviceState *pci_vga_init(PCIBus *bus);
int isa_vga_mm_init(target_phys_addr_t vram_base,
target_phys_addr_t ctrl_base, int it_shift,
MemoryRegion *address_space);
-/* cirrus_vga.c */
-DeviceState *pci_cirrus_vga_init(PCIBus *bus);
-
/* ne2000.c */
static inline bool isa_ne2000_init(ISABus *bus, int base, int irq, NICInfo *nd)
{
diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 37dc019..9abbada 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -23,8 +23,8 @@
*/
#include "hw.h"
#include "console.h"
-#include "pc.h"
#include "pci.h"
+#include "vga-pci.h"
#include "vga_int.h"
#include "pixel_ops.h"
#include "qemu-timer.h"
diff --git a/hw/vga-pci.h b/hw/vga-pci.h
new file mode 100644
index 0000000..49abf13
--- /dev/null
+++ b/hw/vga-pci.h
@@ -0,0 +1,12 @@
+#ifndef VGA_PCI_H
+#define VGA_PCI_H
+
+#include "qemu-common.h"
+
+/* vga-pci.c */
+DeviceState *pci_vga_init(PCIBus *bus);
+
+/* cirrus_vga.c */
+DeviceState *pci_cirrus_vga_init(PCIBus *bus);
+
+#endif
--
1.7.7.6
next prev parent reply other threads:[~2012-08-04 12:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 12:05 [Qemu-devel] [Qemu-ppc][PATCH v6 0/5] Add USB enablement and VGA enablement on sPAPR Li Zhang
2012-08-04 12:05 ` [Qemu-devel] [Qemu-ppc][PATCH v6 1/5] Add USB option in machine options Li Zhang
2012-08-04 12:05 ` [Qemu-devel] [Qemu-ppc][PATCH v6 2/5] Get USB option by machine options on all platforms Li Zhang
2012-08-04 12:05 ` Li Zhang [this message]
2012-08-04 12:43 ` [Qemu-devel] [Qemu-ppc] [PATCH v6 3/5] Add one new file vga-pci.h Blue Swirl
2012-08-04 12:49 ` Li Zhang
2012-08-04 12:56 ` Blue Swirl
2012-08-04 12:05 ` [Qemu-devel] [Qemu-ppc][PATCH v6 4/5] Cleanup pc.h on other platforms Li Zhang
2012-08-04 12:05 ` [Qemu-devel] [Qemu-ppc][PATCH v6 5/5] spapr: Add support for -vga option Li Zhang
[not found] <1344105663-22703-1-git-send-email-zhlcindy@gmail.com>
[not found] ` <1344105663-22703-4-git-send-email-zhlcindy@gmail.com>
2012-08-04 7:54 ` [Qemu-devel] [Qemu-ppc][PATCH v6 3/5] Add one new file vga-pci.h Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344081957-4717-4-git-send-email-zhlcindy@linux.vnet.ibm.com \
--to=zhlcindy@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).