qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
	blauwirbel@gmail.com, anthony@codemonkey.ws, pbonzini@redhat.com,
	eblake@redhat.com, afaerber@suse.de,
	"Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().
Date: Tue,  7 Aug 2012 15:44:26 +0200	[thread overview]
Message-ID: <1344347073-7773-4-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1344347073-7773-1-git-send-email-benoit@irqsave.net>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block/quorum.c |   62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/block/quorum.c b/block/quorum.c
index e0405b6..de58ab8 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -47,11 +47,73 @@ struct QuorumAIOCB {
     int vote_ret;
 };
 
+/* Valid quorum filenames look like
+ * quorum:path/to/a_image:path/to/b_image:path/to/c_image
+ */
+static int quorum_open(BlockDriverState *bs, const char *filename, int flags)
+{
+    BDRVQuorumState *s = bs->opaque;
+    int ret, i;
+    char *a, *b, *c, *filenames[3];
+
+    /* Parse the quorum: prefix */
+    if (strncmp(filename, "quorum:", strlen("quorum:"))) {
+        return -EINVAL;
+    }
+    a = g_strdup(filename + strlen("quorum:"));
+
+    /* Find separators */
+    b = strchr(a, ':');
+    if (b == NULL) {
+        return -EINVAL;
+    }
+
+    c = strrchr(a, ':');
+    if (c == NULL) {
+        return -EINVAL;
+    }
+
+    /* Check that filename contains two separate ':' */
+    if (b == c) {
+        return -EINVAL;
+    }
+
+    /* Split string */
+    *b = '\0';
+    *c = '\0';
+
+    filenames[0] = a;
+    filenames[1] = b + 1;
+    filenames[2] = c + 1;
+
+    /* Open files */
+    for (i = 0; i <= 2; i++) {
+        s->bs[i] = bdrv_new("");
+        ret = bdrv_open(s->bs[i], filenames[i], flags, NULL);
+        if (ret < 0) {
+            goto error_exit;
+        }
+    }
+
+    goto clean_exit;
+
+error_exit:
+    for (; i >= 0; i--) {
+        bdrv_delete(s->bs[i]);
+        s->bs[i] = NULL;
+    }
+clean_exit:
+    g_free(a);
+    return ret;
+}
+
 static BlockDriver bdrv_quorum = {
     .format_name        = "quorum",
     .protocol_name      = "quorum",
 
     .instance_size      = sizeof(BDRVQuorumState),
+
+    .bdrv_file_open     = quorum_open,
 };
 
 static void bdrv_quorum_init(void)
-- 
1.7.9.5

  parent reply	other threads:[~2012-08-07 13:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 13:44 [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency Benoît Canet
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 01/10] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-07 20:24   ` Blue Swirl
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 02/10] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-07 13:44 ` Benoît Canet [this message]
2012-08-07 20:30   ` [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open() Blue Swirl
2012-08-07 20:40     ` Eric Blake
2012-08-10 17:48     ` Benoît Canet
2012-08-13  7:41       ` Kevin Wolf
2012-08-14 16:56         ` Benoît Canet
2012-08-15 10:40           ` Kevin Wolf
2012-08-08 15:04   ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close() Benoît Canet
2012-08-07 20:30   ` Blue Swirl
2012-08-08 15:06     ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength() Benoît Canet
2012-08-08 15:30   ` Stefan Hajnoczi
2012-08-09  9:07     ` Benoît Canet
2012-08-09  9:14       ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-08-08 15:37   ` Stefan Hajnoczi
2012-08-09  9:24     ` Benoît Canet
2012-08-09  9:35       ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 07/10] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public Benoît Canet
2012-08-08 15:38   ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 08/10] quorum: Add quorum_co_flush() Benoît Canet
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 09/10] quorum: Add quorum_aio_readv Benoît Canet
2012-08-08 15:44   ` Stefan Hajnoczi
2012-08-08 15:46     ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 10/10] quorum: Add quorum mechanism Benoît Canet
2012-08-08 15:54   ` Stefan Hajnoczi
2012-08-08 14:55 ` [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency Stefan Hajnoczi
2012-08-10 17:45   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344347073-7773-4-git-send-email-benoit@irqsave.net \
    --to=benoit.canet@gmail.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=benoit@irqsave.net \
    --cc=blauwirbel@gmail.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).