From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Carsten Otte <cotte@de.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Avi Kivity <avi@redhat.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.
Date: Tue, 7 Aug 2012 16:52:45 +0200 [thread overview]
Message-ID: <1344351168-2568-2-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1344351168-2568-1-git-send-email-cornelia.huck@de.ibm.com>
Running under a kvm host does not necessarily imply the presence of
a page mapped above the main memory with the virtio information;
however, the code includes a hard coded access to that page.
Instead, check for the presence of the page and exit gracefully
before we hit an addressing exception if it does not exist.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
drivers/s390/kvm/kvm_virtio.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/s390/kvm/kvm_virtio.c b/drivers/s390/kvm/kvm_virtio.c
index 47cccd5..408447c 100644
--- a/drivers/s390/kvm/kvm_virtio.c
+++ b/drivers/s390/kvm/kvm_virtio.c
@@ -418,6 +418,21 @@ static void kvm_extint_handler(struct ext_code ext_code,
}
}
+static int __init test_devices_support(void)
+{
+ int ccode = -EIO;
+
+ asm volatile(
+ "0: cli 0(%1),0\n"
+ " ipm %0\n"
+ " srl %0,28\n"
+ "1:\n"
+ EX_TABLE(0b,1b)
+ : "+d" (ccode)
+ : "a" (kvm_devices)
+ : "cc");
+ return ccode;
+}
/*
* Init function for virtio
* devices are in a single page above top of "normal" mem
@@ -443,6 +458,12 @@ static int __init kvm_devices_init(void)
}
kvm_devices = (void *) real_memory_size;
+ if (test_devices_support() < 0) {
+ vmem_remove_mapping(real_memory_size, PAGE_SIZE);
+ root_device_unregister(kvm_root);
+ /* No error. */
+ return 0;
+ }
INIT_WORK(&hotplug_work, hotplug_devices);
--
1.7.11.4
next prev parent reply other threads:[~2012-08-07 14:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 14:52 [Qemu-devel] [RFC PATCH 0/4] s390: virtio-ccw guest kernel support Cornelia Huck
2012-08-07 14:52 ` Cornelia Huck [this message]
2012-08-09 10:03 ` [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio Avi Kivity
2012-08-09 10:41 ` Cornelia Huck
2012-08-10 8:42 ` Heiko Carstens
2012-08-10 11:03 ` Cornelia Huck
2012-08-09 23:09 ` Alexander Graf
2012-08-10 7:45 ` Cornelia Huck
2012-08-07 14:52 ` [Qemu-devel] [PATCH 2/4] s390: Add a mechanism to get the subchannel id Cornelia Huck
2012-08-13 17:16 ` Sebastian Ott
2012-08-14 8:52 ` Sebastian Ott
2012-08-14 10:38 ` Cornelia Huck
2012-08-14 10:53 ` Sebastian Ott
2012-08-07 14:52 ` [Qemu-devel] [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver Cornelia Huck
2012-08-08 4:22 ` Rusty Russell
2012-08-13 8:56 ` Cornelia Huck
2012-08-14 0:10 ` Rusty Russell
2012-08-14 11:03 ` Cornelia Huck
2012-08-15 3:15 ` Rusty Russell
2012-08-14 19:56 ` Anthony Liguori
2012-08-15 7:28 ` Rusty Russell
2012-08-15 7:48 ` Christian Borntraeger
2012-08-21 5:35 ` Rusty Russell
2012-08-07 14:52 ` [Qemu-devel] [PATCH 4/4] s390/kvm: Split out early console code Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344351168-2568-2-git-send-email-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).