qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: owasserm@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [RFC PATCH 0/6] Run incoming migration in a coroutine
Date: Tue,  7 Aug 2012 17:51:41 +0200	[thread overview]
Message-ID: <1344354707-27315-1-git-send-email-pbonzini@redhat.com> (raw)

Howdy,

this series moves incoming migration to a coroutine, so that the monitor
remains usable.  I did this is as a step towards implementing an NBD
server inside QEMU (which needs to configured and/or to serve requests
during migration), but I think it is useful in general.

Coroutines work very simply by making the file descriptor non-blocking.
On EAGAIN you call qemu_coroutine_yield(); when the file descriptor
becomes readable, you call qemu_coroutine_enter().

This is mostly an RFC on the approach.  Still, it mostly consists of
cleanups and the first 3 patches could be applied right away.  What
needs some refinement is the hideous passing of file descriptors in
patch 4 and especially the last patch.

Paolo Bonzini (6):
  migration: clean up server sockets and handlers before invoking process_incoming_migration
  migration: close socket QEMUFile from socket_close
  migration: move qemu_fclose to process_incoming_migration
  migration: remove iohandlers before closing the file
  migration: handle EAGAIN while reading QEMUFile
  migration: move process_incoming_migration to a coroutine

 migration-exec.c |  3 +--
 migration-fd.c   |  3 +--
 migration-tcp.c  | 12 ++++++------
 migration-unix.c | 12 ++++++------
 migration.c      | 23 +++++++++++++++++++++--
 migration.h      |  2 +-
 savevm.c         | 34 ++++++++++++++++++++++++++++------
 7 file modificati, 64 inserzioni(+), 25 rimozioni(-)

-- 
1.7.11.2

             reply	other threads:[~2012-08-07 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 15:51 Paolo Bonzini [this message]
2012-08-07 15:51 ` [Qemu-devel] [PATCH 1/6] migration: clean up server sockets and handlers before invoking process_incoming_migration Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 2/6] migration: close socket QEMUFile from socket_close Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 3/6] migration: move qemu_fclose to process_incoming_migration Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 4/6] migration: remove iohandlers before closing the file Paolo Bonzini
2012-08-07 18:46   ` Anthony Liguori
2012-08-08  8:00     ` Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 5/6] migration: handle EAGAIN while reading QEMUFile Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 6/6] migration: move process_incoming_migration to a coroutine Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344354707-27315-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).