From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, "Stefan Hajnoczi" <stefanha@gmail.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemulist@gmail.com, "Blue Swirl" <blauwirbel@gmail.com>,
"Avi Kivity" <avi@redhat.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 10/15] memory: change tcg related code to using PhysMap
Date: Wed, 8 Aug 2012 14:25:51 +0800 [thread overview]
Message-ID: <1344407156-25562-11-git-send-email-qemulist@gmail.com> (raw)
In-Reply-To: <1344407156-25562-1-git-send-email-qemulist@gmail.com>
From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
Change tcg code to use PhysMap.
This is separated from the prev patch for review purpose. Should be
merged into prev one.
Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
exec.c | 27 +++++++++++++++++++++------
1 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/exec.c b/exec.c
index 97addb9..8d0dea5 100644
--- a/exec.c
+++ b/exec.c
@@ -1923,6 +1923,7 @@ target_phys_addr_t memory_region_section_get_iotlb(CPUArchState *env,
{
target_phys_addr_t iotlb;
CPUWatchpoint *wp;
+ PhysMap *map = cur_map_get();
if (memory_region_is_ram(section->mr)) {
/* Normal RAM. */
@@ -1940,7 +1941,7 @@ target_phys_addr_t memory_region_section_get_iotlb(CPUArchState *env,
and avoid full address decoding in every device.
We can't use the high bits of pd for this because
IO_MEM_ROMD uses these as a ram address. */
- iotlb = section - phys_sections;
+ iotlb = section - map->phys_sections;
iotlb += memory_region_section_addr(section, paddr);
}
@@ -1956,6 +1957,7 @@ target_phys_addr_t memory_region_section_get_iotlb(CPUArchState *env,
}
}
}
+ physmap_put(map);
return iotlb;
}
@@ -3185,7 +3187,12 @@ static uint16_t dummy_section(PhysMap *map, MemoryRegion *mr)
MemoryRegion *iotlb_to_region(target_phys_addr_t index)
{
- return phys_sections[index & ~TARGET_PAGE_MASK].mr;
+ MemoryRegion *ret;
+ PhysMap *map = cur_map_get();
+
+ ret = map->phys_sections[index & ~TARGET_PAGE_MASK].mr;
+ physmap_put(map);
+ return ret;
}
static void io_mem_init(void)
@@ -3946,13 +3953,14 @@ void stl_phys_notdirty(target_phys_addr_t addr, uint32_t val)
{
uint8_t *ptr;
MemoryRegionSection *section;
+ PhysMap *map = cur_map_get();
section = phys_page_find(addr >> TARGET_PAGE_BITS);
if (!memory_region_is_ram(section->mr) || section->readonly) {
addr = memory_region_section_addr(section, addr);
if (memory_region_is_ram(section->mr)) {
- section = &phys_sections[phys_section_rom];
+ section = &map->phys_sections[phys_section_rom];
}
io_mem_write(section->mr, addr, val, 4);
} else {
@@ -3972,19 +3980,21 @@ void stl_phys_notdirty(target_phys_addr_t addr, uint32_t val)
}
}
}
+ physmap_put(map);
}
void stq_phys_notdirty(target_phys_addr_t addr, uint64_t val)
{
uint8_t *ptr;
MemoryRegionSection *section;
+ PhysMap *map = cur_map_get();
section = phys_page_find(addr >> TARGET_PAGE_BITS);
if (!memory_region_is_ram(section->mr) || section->readonly) {
addr = memory_region_section_addr(section, addr);
if (memory_region_is_ram(section->mr)) {
- section = &phys_sections[phys_section_rom];
+ section = &map->phys_sections[phys_section_rom];
}
#ifdef TARGET_WORDS_BIGENDIAN
io_mem_write(section->mr, addr, val >> 32, 4);
@@ -3999,6 +4009,7 @@ void stq_phys_notdirty(target_phys_addr_t addr, uint64_t val)
+ memory_region_section_addr(section, addr));
stq_p(ptr, val);
}
+ physmap_put(map);
}
/* warning: addr must be aligned */
@@ -4008,12 +4019,13 @@ static inline void stl_phys_internal(target_phys_addr_t addr, uint32_t val,
uint8_t *ptr;
MemoryRegionSection *section;
+ PhysMap *map = cur_map_get();
section = phys_page_find(addr >> TARGET_PAGE_BITS);
if (!memory_region_is_ram(section->mr) || section->readonly) {
addr = memory_region_section_addr(section, addr);
if (memory_region_is_ram(section->mr)) {
- section = &phys_sections[phys_section_rom];
+ section = &map->phys_sections[phys_section_rom];
}
#if defined(TARGET_WORDS_BIGENDIAN)
if (endian == DEVICE_LITTLE_ENDIAN) {
@@ -4050,6 +4062,7 @@ static inline void stl_phys_internal(target_phys_addr_t addr, uint32_t val,
(0xff & ~CODE_DIRTY_FLAG));
}
}
+ physmap_put(map);
}
void stl_phys(target_phys_addr_t addr, uint32_t val)
@@ -4081,12 +4094,13 @@ static inline void stw_phys_internal(target_phys_addr_t addr, uint32_t val,
uint8_t *ptr;
MemoryRegionSection *section;
+ PhysMap *map = cur_map_get();
section = phys_page_find(addr >> TARGET_PAGE_BITS);
if (!memory_region_is_ram(section->mr) || section->readonly) {
addr = memory_region_section_addr(section, addr);
if (memory_region_is_ram(section->mr)) {
- section = &phys_sections[phys_section_rom];
+ section = &map->phys_sections[phys_section_rom];
}
#if defined(TARGET_WORDS_BIGENDIAN)
if (endian == DEVICE_LITTLE_ENDIAN) {
@@ -4123,6 +4137,7 @@ static inline void stw_phys_internal(target_phys_addr_t addr, uint32_t val,
(0xff & ~CODE_DIRTY_FLAG));
}
}
+ physmap_put(map);
}
void stw_phys(target_phys_addr_t addr, uint32_t val)
--
1.7.4.4
next prev parent reply other threads:[~2012-08-08 6:27 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 6:25 [Qemu-devel] [PATCH 0/15 v2] prepare unplug out of protection of global lock Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 01/15] atomic: introduce atomic operations Liu Ping Fan
2012-08-08 8:55 ` Paolo Bonzini
2012-08-08 9:02 ` Avi Kivity
2012-08-08 9:05 ` 陳韋任 (Wei-Ren Chen)
2012-08-08 9:15 ` Avi Kivity
2012-08-08 9:21 ` Peter Maydell
2012-08-08 13:09 ` Stefan Hajnoczi
2012-08-08 13:18 ` Paolo Bonzini
2012-08-08 13:32 ` Peter Maydell
2012-08-08 13:49 ` Paolo Bonzini
2012-08-08 14:00 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 02/15] qom: using atomic ops to re-implement object_ref Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj Liu Ping Fan
2012-08-08 9:05 ` Avi Kivity
2012-08-08 9:07 ` Paolo Bonzini
2012-08-08 9:15 ` Avi Kivity
2012-08-09 7:33 ` liu ping fan
2012-08-09 7:49 ` Paolo Bonzini
2012-08-09 8:18 ` Avi Kivity
2012-08-10 6:43 ` liu ping fan
2012-08-08 9:35 ` Paolo Bonzini
2012-08-09 7:38 ` liu ping fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating Liu Ping Fan
2012-08-08 9:13 ` Avi Kivity
2012-08-09 7:28 ` liu ping fan
2012-08-09 8:24 ` Avi Kivity
2012-08-10 6:44 ` liu ping fan
2012-08-13 18:28 ` Marcelo Tosatti
2012-08-08 19:17 ` Blue Swirl
2012-08-09 7:28 ` liu ping fan
2012-08-09 17:09 ` Blue Swirl
2012-08-08 6:25 ` [Qemu-devel] [PATCH 05/15] memory: introduce life_ops to MemoryRegion Liu Ping Fan
2012-08-08 9:18 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 06/15] memory: use refcnt to manage MemoryRegion Liu Ping Fan
2012-08-08 9:20 ` Avi Kivity
2012-08-09 7:27 ` liu ping fan
2012-08-09 8:38 ` Avi Kivity
2012-08-10 6:44 ` liu ping fan
2012-08-12 8:43 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy Liu Ping Fan
2012-08-08 9:27 ` Avi Kivity
2012-08-08 19:18 ` Blue Swirl
2012-08-09 7:29 ` liu ping fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access Liu Ping Fan
2012-08-08 9:41 ` Avi Kivity
2012-08-11 1:58 ` liu ping fan
2012-08-11 10:06 ` liu ping fan
2012-08-08 19:23 ` Blue Swirl
2012-08-09 7:29 ` liu ping fan
2012-08-08 6:25 ` Liu Ping Fan [this message]
2012-08-08 6:25 ` [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree Liu Ping Fan
2012-08-08 9:41 ` Paolo Bonzini
2012-08-09 7:28 ` liu ping fan
2012-08-09 7:41 ` Paolo Bonzini
2012-08-08 9:42 ` Avi Kivity
2012-08-09 7:27 ` liu ping fan
2012-08-09 8:31 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 12/15] qdev: using devtree lock to protect device's accessing Liu Ping Fan
2012-08-08 9:33 ` Peter Maydell
2012-08-08 6:25 ` [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views Liu Ping Fan
2012-08-08 9:52 ` Paolo Bonzini
2012-08-08 10:07 ` Avi Kivity
2012-08-09 7:28 ` liu ping fan
2012-08-09 8:00 ` Paolo Bonzini
2012-08-10 6:42 ` liu ping fan
2012-08-13 18:53 ` Marcelo Tosatti
2012-08-13 18:51 ` Marcelo Tosatti
2012-08-08 6:25 ` [Qemu-devel] [PATCH 14/15] qom: object_unref call reclaimer Liu Ping Fan
2012-08-08 9:40 ` Paolo Bonzini
2012-08-13 18:56 ` Marcelo Tosatti
2012-08-08 6:25 ` [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug Liu Ping Fan
2012-08-08 9:56 ` Paolo Bonzini
2012-08-09 7:28 ` liu ping fan
2012-08-09 7:40 ` Paolo Bonzini
2012-08-10 6:43 ` liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344407156-25562-11-git-send-email-qemulist@gmail.com \
--to=qemulist@gmail.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).