From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyzjB-0001FO-R9 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Syzj8-0002PL-6Q for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:45 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:62109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syzj8-0001sm-23 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:42 -0400 Received: by mail-ob0-f173.google.com with SMTP id ta14so635077obb.4 for ; Tue, 07 Aug 2012 23:26:41 -0700 (PDT) From: Liu Ping Fan Date: Wed, 8 Aug 2012 14:25:48 +0800 Message-Id: <1344407156-25562-8-git-send-email-qemulist@gmail.com> In-Reply-To: <1344407156-25562-1-git-send-email-qemulist@gmail.com> References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> Subject: [Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Stefan Hajnoczi , Marcelo Tosatti , qemulist@gmail.com, Blue Swirl , Avi Kivity , Anthony Liguori , Jan Kiszka , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= From: Liu Ping Fan memory_region_{add,del}_subregion will inc/dec mr's refcnt. Signed-off-by: Liu Ping Fan --- memory.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/memory.c b/memory.c index 5dc8b59..2eaa2fc 100644 --- a/memory.c +++ b/memory.c @@ -1356,7 +1356,7 @@ static void memory_region_add_subregion_common(MemoryRegion *mr, assert(!subregion->parent); subregion->parent = mr; subregion->addr = offset; - + memory_region_get(subregion); qemu_mutex_lock(&mem_map_lock); QTAILQ_FOREACH(other, &mr->subregions, subregions_link) { if (subregion->may_overlap || other->may_overlap) { @@ -1420,6 +1420,8 @@ void memory_region_del_subregion(MemoryRegion *mr, qemu_mutex_lock(&mem_map_lock); QTAILQ_REMOVE(&mr->subregions, subregion, subregions_link); memory_region_update_topology(mr); + /* mr may be still in use by reader of radix, must delay to release */ + memory_region_put(subregion); qemu_mutex_unlock(&mem_map_lock); } -- 1.7.4.4