From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] blockdev: flip default cache mode from writethrough to writeback
Date: Thu, 9 Aug 2012 16:07:21 +0200 [thread overview]
Message-ID: <1344521241-22897-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1344521241-22897-1-git-send-email-pbonzini@redhat.com>
Now all major device models (IDE, SCSI, virtio) can choose between
writethrough and writeback at run-time, and virtio will even revert
to writethrough if the guest is not capable of sending flushes. So
we can change the default to writeback at last.
Tested, for lack of a better idea, with a breakpoint on bdrv_open
and all cache choices one by one.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
blockdev.c | 1 +
1 file modificato, 1 inserzione(+)
diff --git a/blockdev.c b/blockdev.c
index 8669142..7c83baa 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -377,6 +377,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
}
}
+ bdrv_flags |= BDRV_O_CACHE_WB;
if ((buf = qemu_opt_get(opts, "cache")) != NULL) {
if (bdrv_parse_cache_flags(buf, &bdrv_flags) != 0) {
error_report("invalid cache option");
--
1.7.11.2
next prev parent reply other threads:[~2012-08-09 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 14:07 [Qemu-devel] [PATCH 0/3] final patches for cache=writeback Paolo Bonzini
2012-08-09 14:07 ` [Qemu-devel] [PATCH 1/3] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE Paolo Bonzini
2012-08-09 14:07 ` [Qemu-devel] [PATCH 2/3] virtio-blk: disable write cache if not negotiated Paolo Bonzini
2012-08-09 14:07 ` Paolo Bonzini [this message]
2012-08-09 14:24 ` [Qemu-devel] [PATCH 0/3] final patches for cache=writeback Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344521241-22897-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).