From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SznJv-0000bj-88 for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:24:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SznJs-0000pZ-Iq for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:23:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SznJs-0000pM-BR for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:23:56 -0400 From: Igor Mammedov Date: Fri, 10 Aug 2012 13:22:36 +0200 Message-Id: <1344597756-2890-21-git-send-email-imammedo@redhat.com> In-Reply-To: <1344597756-2890-1-git-send-email-imammedo@redhat.com> References: <1344597756-2890-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [RFC 20/20] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de, ehabkost@redhat.com Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. PS: Is kvm_features field necessary in cpudef, what the point if it's almost imediately overwritten to ~0? Could it be removed from cpudef? Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 43601a3..e266792 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1093,6 +1093,9 @@ static void cpudef_2_x86_cpu(X86CPU *cpu, x86_def_t *def, Error **errp) env->cpuid_7_0_ebx = def->cpuid_7_0_ebx_features; env->cpuid_xlevel2 = def->xlevel2; + /* not supported bits will be filtered out later */ + env->cpuid_kvm_features = ~0; + object_property_set_bool(OBJECT(cpu), true, "hypervisor", errp); } @@ -1175,9 +1178,6 @@ static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t *x86_cpu_def, cpudef_2_x86_cpu(cpu, def, errp); - /* not supported bits will be filtered out later */ - env->cpuid_kvm_features = ~0; - for (ent = qdict_first(features); ent; ent = qdict_next(features, ent)) { const QString *qval = qobject_to_qstring(qdict_entry_value(ent)); object_property_parse(OBJECT(cpu), qstring_get_str(qval), -- 1.7.11.2