From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SznIw-0006j6-Qq for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:23:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SznIv-0000eD-SO for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:22:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SznIv-0000e7-KO for qemu-devel@nongnu.org; Fri, 10 Aug 2012 07:22:57 -0400 From: Igor Mammedov Date: Fri, 10 Aug 2012 13:22:19 +0200 Message-Id: <1344597756-2890-4-git-send-email-imammedo@redhat.com> In-Reply-To: <1344597756-2890-1-git-send-email-imammedo@redhat.com> References: <1344597756-2890-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [RFC 03/20] target-i386: if x86_cpu_realize() failed report error and do cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de, ehabkost@redhat.com Signed-off-by: Igor Mammedov --- target-i386/helper.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 8a5da3d..a0e4c89 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1151,6 +1151,7 @@ X86CPU *cpu_x86_init(const char *cpu_model) { X86CPU *cpu; CPUX86State *env; + Error *error = NULL; cpu = X86_CPU(object_new(TYPE_X86_CPU)); env = &cpu->env; @@ -1161,8 +1162,12 @@ X86CPU *cpu_x86_init(const char *cpu_model) return NULL; } - x86_cpu_realize(OBJECT(cpu), NULL); - + x86_cpu_realize(OBJECT(cpu), &error); + if (error_is_set(&error)) { + error_free(error); + object_delete(OBJECT(cpu)); + return NULL; + } return cpu; } -- 1.7.11.2