From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0q4o-0003De-MW for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0q4i-0001ms-Up for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:32:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0q4i-0001mn-MZ for qemu-devel@nongnu.org; Mon, 13 Aug 2012 04:32:36 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7D8WZFX000768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 04:32:35 -0400 From: Christophe Fergeau Date: Mon, 13 Aug 2012 10:32:32 +0200 Message-Id: <1344846752-3485-1-git-send-email-cfergeau@redhat.com> Subject: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yonit Halperin , Gerd Hoffmann When parsing its command line parameters, spice aborts when it finds unexpected values, except for the 'streaming-video' option. This happens because the parsing of the parameters for this option is done using the 'name2enum' helper, which does not error out on unknown values. Using the 'parse_name' helper makes sure we error out in this case. Looking at git history, the use of 'name2enum' instead of 'parse_name' seems to have been an oversight, so let's change to that now. Fixes rhbz#831708 --- ui/spice-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 4fc48f8..bb4f585 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -344,7 +344,8 @@ static const char *stream_video_names[] = { [ SPICE_STREAM_VIDEO_FILTER ] = "filter", }; #define parse_stream_video(_name) \ - name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names)) + parse_name(_name, "stream video control", \ + stream_video_names, ARRAY_SIZE(stream_video_names)) static const char *compression_names[] = { [ SPICE_IMAGE_COMPRESS_OFF ] = "off", -- 1.7.11.2