* [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params
@ 2012-08-13 8:32 Christophe Fergeau
2012-08-13 9:00 ` Yonit Halperin
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Fergeau @ 2012-08-13 8:32 UTC (permalink / raw)
To: qemu-devel; +Cc: Yonit Halperin, Gerd Hoffmann
When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name' helper makes sure we
error out in this case. Looking at git history, the use of
'name2enum' instead of 'parse_name' seems to have been an oversight,
so let's change to that now.
Fixes rhbz#831708
---
ui/spice-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 4fc48f8..bb4f585 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -344,7 +344,8 @@ static const char *stream_video_names[] = {
[ SPICE_STREAM_VIDEO_FILTER ] = "filter",
};
#define parse_stream_video(_name) \
- name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names))
+ parse_name(_name, "stream video control", \
+ stream_video_names, ARRAY_SIZE(stream_video_names))
static const char *compression_names[] = {
[ SPICE_IMAGE_COMPRESS_OFF ] = "off",
--
1.7.11.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params
2012-08-13 8:32 [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params Christophe Fergeau
@ 2012-08-13 9:00 ` Yonit Halperin
0 siblings, 0 replies; 2+ messages in thread
From: Yonit Halperin @ 2012-08-13 9:00 UTC (permalink / raw)
To: Christophe Fergeau; +Cc: qemu-devel, Gerd Hoffmann
Ack
On 08/13/2012 11:32 AM, Christophe Fergeau wrote:
> When parsing its command line parameters, spice aborts when it
> finds unexpected values, except for the 'streaming-video' option.
> This happens because the parsing of the parameters for this option
> is done using the 'name2enum' helper, which does not error out
> on unknown values. Using the 'parse_name' helper makes sure we
> error out in this case. Looking at git history, the use of
> 'name2enum' instead of 'parse_name' seems to have been an oversight,
> so let's change to that now.
>
> Fixes rhbz#831708
> ---
> ui/spice-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 4fc48f8..bb4f585 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -344,7 +344,8 @@ static const char *stream_video_names[] = {
> [ SPICE_STREAM_VIDEO_FILTER ] = "filter",
> };
> #define parse_stream_video(_name) \
> - name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names))
> + parse_name(_name, "stream video control", \
> + stream_video_names, ARRAY_SIZE(stream_video_names))
>
> static const char *compression_names[] = {
> [ SPICE_IMAGE_COMPRESS_OFF ] = "off",
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-13 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 8:32 [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params Christophe Fergeau
2012-08-13 9:00 ` Yonit Halperin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).