From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime
Date: Mon, 13 Aug 2012 12:50:54 +0200 [thread overview]
Message-ID: <1344855057-32509-5-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1344855057-32509-1-git-send-email-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
arch_init.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 9b46bfc..5559d68 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -537,7 +537,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
double bwidth = 0;
int ret;
int i;
- uint64_t expected_time;
+ uint64_t expected_downtime;
bytes_transferred_last = bytes_transferred;
bwidth = qemu_get_clock_ns(rt_clock);
@@ -576,24 +576,25 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
bwidth = qemu_get_clock_ns(rt_clock) - bwidth;
bwidth = (bytes_transferred - bytes_transferred_last) / bwidth;
- /* if we haven't transferred anything this round, force expected_time to a
- * a very high value, but without crashing */
+ /* if we haven't transferred anything this round, force
+ * expected_downtime to a a very high value, but without
+ * crashing */
if (bwidth == 0) {
bwidth = 0.000001;
}
qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
- expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
+ expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
DPRINTF("ram_save_live: expected(" PRIu64 ") <= max(" PRIu64 ")?\n",
- expected_time, migrate_max_downtime());
+ expected_downtime, migrate_max_downtime());
- if (expected_time <= migrate_max_downtime()) {
+ if (expected_downtime <= migrate_max_downtime()) {
memory_global_sync_dirty_bitmap(get_system_memory());
- expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
+ expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
- return expected_time <= migrate_max_downtime();
+ return expected_downtime <= migrate_max_downtime();
}
return 0;
}
--
1.7.11.2
next prev parent reply other threads:[~2012-08-13 10:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 10:50 [Qemu-devel] [RFC 0/7] Migration stats Juan Quintela
2012-08-13 10:50 ` [Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info Juan Quintela
2012-08-13 14:32 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable Juan Quintela
2012-08-13 15:01 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration Juan Quintela
2012-08-13 15:02 ` Eric Blake
2012-08-13 15:03 ` Eric Blake
2012-08-13 19:36 ` Luiz Capitulino
2012-08-13 10:50 ` Juan Quintela [this message]
2012-08-13 15:05 ` [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 5/7] migration: export migration_get_current() Juan Quintela
2012-08-13 15:06 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate Juan Quintela
2012-08-13 15:08 ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output Juan Quintela
2012-08-13 15:12 ` Eric Blake
2012-08-13 16:04 ` Juan Quintela
2012-08-13 16:49 ` Eric Blake
2012-08-13 14:59 ` [Qemu-devel] [RFC 0/7] Migration stats Eric Blake
2012-08-13 15:08 ` Juan Quintela
2012-08-13 15:14 ` Eric Blake
2012-08-13 19:47 ` Luiz Capitulino
2012-08-16 10:25 ` Qunfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344855057-32509-5-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).