qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output
Date: Mon, 13 Aug 2012 12:50:57 +0200	[thread overview]
Message-ID: <1344855057-32509-8-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1344855057-32509-1-git-send-email-quintela@redhat.com>

For now this is a placeholder, real info will appear once the bitmap
changes in the migration thread series is integrated.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hmp.c            | 4 ++++
 migration.c      | 2 ++
 migration.h      | 1 +
 qapi-schema.json | 6 +++++-
 4 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/hmp.c b/hmp.c
index fc75ec3..dd40631 100644
--- a/hmp.c
+++ b/hmp.c
@@ -174,6 +174,10 @@ void hmp_info_migrate(Monitor *mon)
                        info->ram->normal);
         monitor_printf(mon, "normal bytes: %" PRIu64 " kbytes\n",
                        info->ram->normal_bytes >> 10);
+        if (info->ram->dirty_pages_rate) {
+            monitor_printf(mon, "dirty pages rate: %" PRIu64 " pagfes\n",
+                           info->ram->dirty_pages_rate);
+        }
     }

     if (info->has_disk) {
diff --git a/migration.c b/migration.c
index 28e23db..8d67e9b 100644
--- a/migration.c
+++ b/migration.c
@@ -178,6 +178,8 @@ MigrationInfo *qmp_query_migrate(Error **errp)
         info->ram->duplicate = dup_mig_pages_transferred();
         info->ram->normal = norm_mig_pages_transferred();
         info->ram->normal_bytes = norm_mig_bytes_transferred();
+        info->ram->dirty_pages_rate = s->dirty_pages_rate;
+

         if (blk_mig_active()) {
             info->has_disk = true;
diff --git a/migration.h b/migration.h
index 552200c..66d7f68 100644
--- a/migration.h
+++ b/migration.h
@@ -42,6 +42,7 @@ struct MigrationState
     int64_t total_time;
     int64_t downtime;
     int64_t expected_downtime;
+    int64_t dirty_pages_rate;
     bool enabled_capabilities[MIGRATION_CAPABILITY_MAX];
     int64_t xbzrle_cache_size;
 };
diff --git a/qapi-schema.json b/qapi-schema.json
index 3dcc12f..55ef73c 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -266,11 +266,15 @@
 #
 # @normal-bytes : number of normal bytes sent (since 1.2)
 #
+# @dirty-pages-rate: number of pages dirtied by second by the
+#        guest. (since 1.2)
+#
 # Since: 0.14.0
 ##
 { 'type': 'MigrationStats',
   'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
-           'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } }
+           'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int',
+           'dirty-pages-rate' : 'int' } }

 ##
 # @XBZRLECacheStats
-- 
1.7.11.2

  parent reply	other threads:[~2012-08-13 10:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 10:50 [Qemu-devel] [RFC 0/7] Migration stats Juan Quintela
2012-08-13 10:50 ` [Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info Juan Quintela
2012-08-13 14:32   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable Juan Quintela
2012-08-13 15:01   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration Juan Quintela
2012-08-13 15:02   ` Eric Blake
2012-08-13 15:03     ` Eric Blake
2012-08-13 19:36   ` Luiz Capitulino
2012-08-13 10:50 ` [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime Juan Quintela
2012-08-13 15:05   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 5/7] migration: export migration_get_current() Juan Quintela
2012-08-13 15:06   ` Eric Blake
2012-08-13 10:50 ` [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate Juan Quintela
2012-08-13 15:08   ` Eric Blake
2012-08-13 10:50 ` Juan Quintela [this message]
2012-08-13 15:12   ` [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output Eric Blake
2012-08-13 16:04     ` Juan Quintela
2012-08-13 16:49       ` Eric Blake
2012-08-13 14:59 ` [Qemu-devel] [RFC 0/7] Migration stats Eric Blake
2012-08-13 15:08   ` Juan Quintela
2012-08-13 15:14     ` Eric Blake
2012-08-13 19:47   ` Luiz Capitulino
2012-08-16 10:25 ` Qunfang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344855057-32509-8-git-send-email-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).