qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <aliguori@us.ibm.com>, Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 02/10] armv7m: Guard against no -kernel argument
Date: Mon, 13 Aug 2012 16:31:51 +0100	[thread overview]
Message-ID: <1344871919-31559-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1344871919-31559-1-git-send-email-peter.maydell@linaro.org>

From: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>

A -kernel argument must be specified for this machine. Guard against no -kernel
argument. Previously gave an unhelpful "bad address" error message.

Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
Tested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/armv7m.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/armv7m.c b/hw/armv7m.c
index 8cec78d..9f66667 100644
--- a/hw/armv7m.c
+++ b/hw/armv7m.c
@@ -227,6 +227,11 @@ qemu_irq *armv7m_init(MemoryRegion *address_space_mem,
     big_endian = 0;
 #endif
 
+    if (!kernel_filename) {
+        fprintf(stderr, "Guest image must be specified (using -kernel)\n");
+        exit(1);
+    }
+
     image_size = load_elf(kernel_filename, NULL, NULL, &entry, &lowaddr,
                           NULL, big_endian, ELF_MACHINE, 1);
     if (image_size < 0) {
-- 
1.7.9.5

  parent reply	other threads:[~2012-08-13 15:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 15:31 [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property Peter Maydell
2012-08-13 20:34   ` Meador Inge
2012-08-13 15:31 ` Peter Maydell [this message]
2012-08-13 15:31 ` [Qemu-devel] [PATCH 03/10] hw/sd.c: convert wp_groups in SDState to bitfield Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 04/10] hw/sd.c: make sd_wp_addr() accept 64 bit address argument Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 05/10] hw/sd.c: introduce wrapper for conversion address to wp group Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 06/10] hw/sd.c: convert binary variables to bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 07/10] hw/sd.c: make sd_dataready() return bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 08/10] hw/sd.c: make sd_wp_addr() " Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 09/10] ssd0323: abort() instead of exit(1) on error Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 10/10] arm: Move some ARM devices into libhw Peter Maydell
2012-08-14  0:12 ` [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344871919-31559-3-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).