From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <aliguori@us.ibm.com>, Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 04/10] hw/sd.c: make sd_wp_addr() accept 64 bit address argument
Date: Mon, 13 Aug 2012 16:31:53 +0100 [thread overview]
Message-ID: <1344871919-31559-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1344871919-31559-1-git-send-email-peter.maydell@linaro.org>
From: Mitsyanko Igor <i.mitsyanko@samsung.com>
Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly
restricting SD card address range. Change address argument type to uint64_t.
Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd.c b/hw/sd.c
index 575b509..e24d04a 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -539,7 +539,7 @@ static void sd_function_switch(SDState *sd, uint32_t arg)
sd->data[66] = crc & 0xff;
}
-static inline int sd_wp_addr(SDState *sd, uint32_t addr)
+static inline int sd_wp_addr(SDState *sd, uint64_t addr)
{
return test_bit(addr >> (HWBLOCK_SHIFT + SECTOR_SHIFT + WPGROUP_SHIFT),
sd->wp_groups);
--
1.7.9.5
next prev parent reply other threads:[~2012-08-13 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:31 [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property Peter Maydell
2012-08-13 20:34 ` Meador Inge
2012-08-13 15:31 ` [Qemu-devel] [PATCH 02/10] armv7m: Guard against no -kernel argument Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 03/10] hw/sd.c: convert wp_groups in SDState to bitfield Peter Maydell
2012-08-13 15:31 ` Peter Maydell [this message]
2012-08-13 15:31 ` [Qemu-devel] [PATCH 05/10] hw/sd.c: introduce wrapper for conversion address to wp group Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 06/10] hw/sd.c: convert binary variables to bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 07/10] hw/sd.c: make sd_dataready() return bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 08/10] hw/sd.c: make sd_wp_addr() " Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 09/10] ssd0323: abort() instead of exit(1) on error Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 10/10] arm: Move some ARM devices into libhw Peter Maydell
2012-08-14 0:12 ` [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344871919-31559-5-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).