qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 42/48] qmp: introduce device-list-properties command
Date: Mon, 13 Aug 2012 16:49:03 -0300	[thread overview]
Message-ID: <1344887349-13041-43-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1344887349-13041-1-git-send-email-lcapitulino@redhat.com>

From: Anthony Liguori <aliguori@us.ibm.com>

This can be used in conjunction with qom-list-types to determine the supported
set of devices and their parameters.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qapi-schema.json | 28 ++++++++++++++++++++++++++++
 qmp-commands.hx  |  7 +++++++
 qmp.c            | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 85 insertions(+)

diff --git a/qapi-schema.json b/qapi-schema.json
index ec8d919..927fdea 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1725,6 +1725,34 @@
   'returns': [ 'ObjectTypeInfo' ] }
 
 ##
+# @DevicePropertyInfo:
+#
+# Information about device properties.
+#
+# @name: the name of the property
+# @type: the typename of the property
+#
+# Since: 1.2
+##
+{ 'type': 'DevicePropertyInfo',
+  'data': { 'name': 'str', 'type': 'str' } }
+
+##
+# @device-list-properties:
+#
+# List properties associated with a device.
+#
+# @typename: the type name of a device
+#
+# Returns: a list of DevicePropertyInfo describing a devices properties
+#
+# Since: 1.2
+##
+{ 'command': 'device-list-properties',
+  'data': { 'typename': 'str'},
+  'returns': [ 'DevicePropertyInfo' ] }
+
+##
 # @migrate
 #
 # Migrates the current running guest to another Virtual Machine.
diff --git a/qmp-commands.hx b/qmp-commands.hx
index e07c7b0..e9e0410 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2217,3 +2217,10 @@ EQMP
         .args_type  = "implements:s?,abstract:b?",
         .mhandler.cmd_new = qmp_marshal_input_qom_list_types,
     },
+
+    {
+        .name       = "device-list-properties",
+        .args_type  = "typename:s",
+        .mhandler.cmd_new = qmp_marshal_input_device_list_properties,
+    },
+
diff --git a/qmp.c b/qmp.c
index fee9fb2..254a32f 100644
--- a/qmp.c
+++ b/qmp.c
@@ -417,3 +417,53 @@ ObjectTypeInfoList *qmp_qom_list_types(bool has_implements,
 
     return ret;
 }
+
+DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
+                                                   Error **errp)
+{
+    ObjectClass *klass;
+    Property *prop;
+    DevicePropertyInfoList *prop_list = NULL;
+
+    klass = object_class_by_name(typename);
+    if (klass == NULL) {
+        error_set(errp, QERR_DEVICE_NOT_FOUND, typename);
+        return NULL;
+    }
+
+    klass = object_class_dynamic_cast(klass, TYPE_DEVICE);
+    if (klass == NULL) {
+        error_set(errp, QERR_INVALID_PARAMETER_VALUE,
+                  "name", TYPE_DEVICE);
+        return NULL;
+    }
+
+    do {
+        for (prop = DEVICE_CLASS(klass)->props; prop && prop->name; prop++) {
+            DevicePropertyInfoList *entry;
+            DevicePropertyInfo *info;
+
+            /*
+             * TODO Properties without a parser are just for dirty hacks.
+             * qdev_prop_ptr is the only such PropertyInfo.  It's marked
+             * for removal.  This conditional should be removed along with
+             * it.
+             */
+            if (!prop->info->set) {
+                continue;           /* no way to set it, don't show */
+            }
+
+            info = g_malloc0(sizeof(*info));
+            info->name = g_strdup(prop->name);
+            info->type = g_strdup(prop->info->legacy_name ?: prop->info->name);
+
+            entry = g_malloc0(sizeof(*entry));
+            entry->value = info;
+            entry->next = prop_list;
+            prop_list = entry;
+        }
+        klass = object_class_get_parent(klass);
+    } while (klass != object_class_by_name(TYPE_DEVICE));
+
+    return prop_list;
+}
-- 
1.7.11.2.249.g31c7954.dirty

  parent reply	other threads:[~2012-08-13 19:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 19:48 [Qemu-devel] [PULL 00/48]: QMP queue Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 01/48] monitor: drop unused monitor debug code Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 02/48] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 03/48] qerror: QERR_DEVICE_ENCRYPTED: change error message Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 04/48] qerror: reduce public exposure Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 05/48] qerror: drop qerror_abort() Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 06/48] qerror: avoid passing qerr pointer Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 07/48] qerror: QError: drop file, linenr, func Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 08/48] qerror: qerror_format(): return an allocated string Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 09/48] qerror: don't delay error message construction Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 10/48] error: " Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 11/48] qmp: query-block: add 'encryption_key_missing' field Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 12/48] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 13/48] hmp_change(): don't access DeviceEncrypted's data Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 14/48] net: inet_connect(), inet_connect_opts(): add in_progress argument Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 15/48] migration: don't rely on any QERR_SOCKET_* Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 16/48] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 17/48] block: block_int: include qerror.h Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 18/48] hmp: hmp.h: include qdict.h Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 19/48] qapi: qapi-types.h: don't include qapi/qapi-types-core.h Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 20/48] qapi: generate correct enum names for camel case enums Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 21/48] qapi: don't convert enum strings to lowercase Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 22/48] qapi-schema: add ErrorClass enum Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 23/48] qerror: qerror_table: don't use C99 struct initializers Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 24/48] error, qerror: add ErrorClass argument to error functions Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 25/48] qerror: add proper ErrorClass value for QERR_ macros Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 26/48] error: add error_get_class() Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 27/48] hmp: hmp_change(): use error_get_class() Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 28/48] error: drop unused functions Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 29/48] qmp: switch to the new error format on the wire Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 30/48] qemu-ga: " Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 31/48] error: drop error_get_qobject()/error_set_qobject() Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 32/48] error, qerror: pass desc string to error calls Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 33/48] qerror: drop qerror_table and qerror_format() Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 34/48] error, qerror: drop QDict member Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 35/48] docs: writing-qmp-commands.txt: update error section Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 36/48] scripts: qapi-commands.py: qmp-commands.h: include qdict.h Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 37/48] qmp: don't emit the RESET event on wakeup from S3 Luiz Capitulino
2012-08-13 19:48 ` [Qemu-devel] [PATCH 38/48] qmp: emit the WAKEUP event when the guest is put to run Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 39/48] qmp: qmp-events.txt: put events in alphabetical order Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 40/48] qmp: qmp-events.txt: add missing doc for the SUSPEND event Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 41/48] qmp: add SUSPEND_DISK event Luiz Capitulino
2012-08-13 19:49 ` Luiz Capitulino [this message]
2012-08-13 19:49 ` [Qemu-devel] [PATCH 43/48] qapi: mark QOM commands stable Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 44/48] qapi: add query-machines command Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 45/48] compiler: add macro for GCC weak symbols Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 46/48] qapi: add query-cpu-definitions command (v2) Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 47/48] target-i386: add implementation of query-cpu-definitions (v2) Luiz Capitulino
2012-08-13 19:49 ` [Qemu-devel] [PATCH 48/48] target-ppc: " Luiz Capitulino
2012-08-14  0:12 ` [Qemu-devel] [PULL 00/48]: QMP queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344887349-13041-43-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).