From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11gR-0007ME-7Q for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T11gP-00015W-IC for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11gP-00014z-AQ for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:17 -0400 Message-ID: <1344891355.4683.126.camel@ul30vt.home> From: Alex Williamson Date: Mon, 13 Aug 2012 14:55:55 -0600 In-Reply-To: <87zk5ylh87.fsf@codemonkey.ws> References: <20120801050241.22163.78549.stgit@bling.home> <87pq6uvs52.fsf@codemonkey.ws> <1344867810.4683.21.camel@ul30vt.home> <87zk5ylh87.fsf@codemonkey.ws> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] VFIO: Call for reviewers (was Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Alexey Kardashevskiy , Jan Kiszka , Blue Swirl Cc: Andreas Hartmann , kvm@vger.kernel.org, qemu-devel@nongnu.org, Avi Kivity On Mon, 2012-08-13 at 14:33 -0500, Anthony Liguori wrote: > Alex Williamson writes: > > > On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote: > >> Alex Williamson writes: > >> > >> > VFIO kernel support was just merged into Linux, so I'd like to > >> > formally propose inclusion of the QEMU vfio-pci driver for > >> > QEMU 1.2. Included here is support for x86 PCI device assignment. > >> > PCI INTx is not yet enabled, but devices making use of either MSI > >> > or MSI-X work. The level irqfd and eoifd support I've proposed > >> > for KVM enable an accelerated patch for this through KVM. I'd > >> > like to get this base driver in first and enable the remaining > >> > support in-tree. > >> > > >> > I've split this version up a little from the RFC to make it a bit > >> > easier to review. Review comments from Blue Swirl and Avi are > >> > already incorporated, including Avi's requests to simplify both > >> > the PCI BAR mapping and unmapping paths. > >> > >> Hi Alex, > >> > >> Thanks for pushing this forward! Hopefully this will finally kill off > >> qemu-kvm.git for good. > >> > >> I think this series is going to have to wait for 1.3 to open up. We > >> have a very short release window for this release and I'd feel a lot > >> more comfortable having such a significant feature spend some time in > >> the development cycle getting testing/review. > >> > >> I'd like to see a few Reviewed-by's too for this series before it goes > >> in. I expect they won't be hard to get but I also expect it will take a > >> few more revisions of this series to get there. > > > > That's disappointing, but I can understand your reluctance. Blue Swirl > > reviewed the RFC and could perhaps add a Reviewed-by. Alexey has been > > working on the POWER port and I'm sure could provide a Reviewed-by. We > > also have a few early adopters that are already making use of this code. > > Towards accepting it, the driver is entirely self contained, there's > > really no risk to the rest of qemu. The only missing functionality is > > legacy interrupt support. Perhaps there's a compromise where this > > driver could be considered a tech preview in 1.2 (x-vfio-pci?). > > Thanks, > > Yeah, if a few people were willing to at least give an Acked-by by > Wednesday, I'd be okay taking this in a "preview" or something like > that. Alexey, Blue, Jan, if any of you have time to review the current VFIO series (linked below) to help it become a preview release in 1.2 I'd very much appreciate it. Reviews from anyone else also appreciated. Thanks! http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg00545.html > I wouldn't bother renaming it or anything like that. We can just > declare in the release notes that it's an experimental feature and may > eat your lunch while you're not looking. Ok, thanks, Alex