Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported

[Alex Williamson <alex.williamson@redhat.com>]

On Mon, 2012-08-13 at 17:19 -0500, Anthony Liguori wrote:
> Jan Kiszka <jan.kiszka@web.de> writes:
> 
> > On 2012-08-01 07:18, Alex Williamson wrote:
> >> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >> ---
> >> 
> >>  MAINTAINERS           |    5 +++++
> >>  configure             |   12 ++++++++++++
> >>  hw/i386/Makefile.objs |    1 +
> >>  3 files changed, 18 insertions(+)
> >> 
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 2d219d2..9680d69 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -460,6 +460,11 @@ M: Gerd Hoffmann <kraxel@redhat.com>
> >>  S: Maintained
> >>  F: hw/usb*
> >>  
> >> +VFIO
> >> +M: Alex Williamson <alex.williamson@redhat.com>
> >> +S: Supported
> >> +F: hw/vfio*
> >> +
> >>  vhost
> >>  M: Michael S. Tsirkin <mst@redhat.com>
> >>  S: Supported
> >> diff --git a/configure b/configure
> >> index c65b5f6..81108dc 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -143,6 +143,7 @@ attr=""
> >>  libattr=""
> >>  xfs=""
> >>  
> >> +vfio_pci="no"
> >>  vhost_net="no"
> >>  kvm="no"
> >>  gprof="no"
> >> @@ -489,6 +490,7 @@ Haiku)
> >>    usb="linux"
> >>    kvm="yes"
> >>    vhost_net="yes"
> >> +  vfio_pci="yes"
> >>    if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> >>      audio_possible_drivers="$audio_possible_drivers fmod"
> >>    fi
> >> @@ -824,6 +826,10 @@ for opt do
> >>    ;;
> >>    --disable-guest-agent) guest_agent="no"
> >>    ;;
> >> +  --disable-vfio-pci) vfio_pci="no"
> >> +  ;;
> >> +  --enable-vfio-pci) vfio_pci="yes"
> >> +  ;;
> >
> > Do we need this level of control? Open question I'm just wondering every
> > time a new feature gets added together with --disable/--enable
> > switches.
> 
> I don't think so--it's easy enough for an administrator to disable vfio
> for a user.

Ok, out voted.  I'll remove.  Thanks,

Alex