From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 1/6] trace: rename TraceRecordHeader to TraceLogHeader
Date: Tue, 14 Aug 2012 13:56:23 +0100 [thread overview]
Message-ID: <1344948988-8627-2-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1344948988-8627-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
The TraceRecordHeader is really the header for the entire trace log
file. It's not per-record header so make this obvious by renaming it.
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
trace/simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index b700ea3..5d92939 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -70,7 +70,7 @@ typedef struct {
uint64_t header_event_id; /* HEADER_EVENT_ID */
uint64_t header_magic; /* HEADER_MAGIC */
uint64_t header_version; /* HEADER_VERSION */
-} TraceRecordHeader;
+} TraceLogHeader;
static void read_from_buffer(unsigned int idx, void *dataptr, size_t size);
@@ -295,7 +295,7 @@ void st_set_trace_file_enabled(bool enable)
flush_trace_file(true);
if (enable) {
- static const TraceRecordHeader header = {
+ static const TraceLogHeader header = {
.header_event_id = HEADER_EVENT_ID,
.header_magic = HEADER_MAGIC,
/* Older log readers will check for version at next location */
--
1.7.10.4
next prev parent reply other threads:[~2012-08-14 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 12:56 [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2 Stefan Hajnoczi
2012-08-14 12:56 ` Stefan Hajnoczi [this message]
2012-08-14 12:56 ` [Qemu-devel] [PATCH 2/6] trace: remove unnecessary write_to_buffer() typecasting Stefan Hajnoczi
2012-08-14 12:56 ` [Qemu-devel] [PATCH 3/6] trace: drop unused TraceBufferRecord->next_tbuf_idx field Stefan Hajnoczi
2012-08-14 12:56 ` [Qemu-devel] [PATCH 4/6] trace: avoid pointer aliasing in trace_record_finish() Stefan Hajnoczi
2012-08-14 12:56 ` [Qemu-devel] [PATCH 5/6] trace/simple: Fix compiler warning for 32 bit hosts Stefan Hajnoczi
2012-08-14 12:56 ` [Qemu-devel] [PATCH 6/6] trace/simple: Replace asprintf by g_strdup_printf Stefan Hajnoczi
2012-08-14 18:44 ` [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2 Anthony Liguori
2012-08-15 7:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344948988-8627-2-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).