From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
blauwirbel@gmail.com, anthony@codemonkey.ws, pbonzini@redhat.com,
eblake@redhat.com, afaerber@suse.de,
"Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close().
Date: Tue, 14 Aug 2012 16:14:05 +0200 [thread overview]
Message-ID: <1344953651-16622-4-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1344953651-16622-1-git-send-email-benoit@irqsave.net>
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
block/quorum.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 113 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index bab6175..f228428 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -52,11 +52,124 @@ struct QuorumAIOCB {
int vote_ret;
};
+/* Valid quorum filenames look like
+ * quorum:n/m:path/to/image_1, ... ,path/to/image_m
+ */
+static int quorum_open(BlockDriverState *bs, const char *filename, int flags)
+{
+ BDRVQuorumState *s = bs->opaque;
+ int escape, i, j, len, ret = 0;
+ char *a, *b, *names;
+
+ /* Parse the quorum: prefix */
+ if (strncmp(filename, "quorum:", strlen("quorum:"))) {
+ return -EINVAL;
+ }
+
+ filename += strlen("quorum:");
+
+ /* Get n */
+ errno = 0;
+ s->n = strtoul(filename, &a, 10);
+ if (*a != '/' || errno) {
+ return -EINVAL;
+ }
+ a += 1;
+
+ /* Get m */
+ errno = 0;
+ s->m = strtoul(a, &b, 10);
+ if (*b != ':' || errno) {
+ return -EINVAL;
+ }
+ b += 1;
+
+ if (s->n < 1 || s->m < 2) {
+ return -EINVAL;
+ }
+
+ if (s->n > s->m) {
+ return -EINVAL;
+ }
+
+ s->bs = g_malloc0(sizeof(BlockDriverState *) * s->m);
+ /* Two allocations for all filenames: simpler to free */
+ s->filenames = g_malloc0(sizeof(char *) * s->m);
+ names = g_strdup(b);
+
+ /* Get the filenames pointers */
+ escape = 0;
+ s->filenames[0] = names;
+ len = strlen(names);
+ for (i = 0, j = 1; i < len && j < s->m; i++) {
+ if (!escape && names[i] == ':') {
+ names[i] = '\0';
+ s->filenames[j] = names + i + 1;
+ j += 1;
+ }
+
+ if (!escape && names[i] == '\\') {
+ escape = 1;
+ } else {
+ escape = 0;
+ }
+ }
+
+ if (j != s->m) {
+ ret = -EINVAL;
+ goto free_exit;
+ }
+
+ /* Open files */
+ for (i = 0; i < s->m; i++) {
+ s->bs[i] = bdrv_new("");
+ ret = bdrv_open(s->bs[i], s->filenames[i], flags, NULL);
+ if (ret < 0) {
+ goto error_exit;
+ }
+ }
+
+ goto exit;
+
+error_exit:
+ for (; i >= 0; i--) {
+ bdrv_delete(s->bs[i]);
+ s->bs[i] = NULL;
+ }
+free_exit:
+ g_free(s->filenames[0]);
+ g_free(s->filenames);
+ s->filenames = NULL;
+ g_free(s->bs);
+exit:
+ return ret;
+}
+
+static void quorum_close(BlockDriverState *bs)
+{
+ BDRVQuorumState *s = bs->opaque;
+ int i;
+
+ for (i = 0; i < s->m; i++) {
+ /* Ensure writes reach stable storage */
+ bdrv_flush(s->bs[i]);
+ bdrv_delete(s->bs[i]);
+ }
+
+ g_free(s->filenames[0]);
+ g_free(s->filenames);
+ s->filenames = NULL;
+ g_free(s->bs);
+}
+
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
.protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState),
+
+ .bdrv_file_open = quorum_open,
+ .bdrv_close = quorum_close,
};
static void bdrv_quorum_init(void)
--
1.7.9.5
next prev parent reply other threads:[~2012-08-14 14:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:14 [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-14 14:14 ` Benoît Canet [this message]
2012-08-14 14:45 ` [Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close() Eric Blake
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength() Benoît Canet
2012-08-14 16:08 ` Eric Blake
2012-08-16 13:18 ` Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 5/9] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 6/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush() Benoît Canet
2012-08-14 18:52 ` Blue Swirl
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv Benoît Canet
2012-08-15 10:53 ` Stefan Hajnoczi
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism Benoît Canet
2012-08-15 10:51 ` Stefan Hajnoczi
2012-08-14 18:47 ` [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Blue Swirl
2012-08-15 13:12 ` Stefan Hajnoczi
2012-08-20 10:12 ` Benoît Canet
2012-08-20 11:23 ` Stefan Hajnoczi
2012-08-20 11:24 ` Stefan Hajnoczi
2012-08-20 11:42 ` Benoît Canet
2012-08-20 12:56 ` Stefan Hajnoczi
2012-08-20 14:03 ` Benoît Canet
2012-08-20 15:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344953651-16622-4-git-send-email-benoit@irqsave.net \
--to=benoit.canet@gmail.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=benoit@irqsave.net \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).