qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
	blauwirbel@gmail.com, anthony@codemonkey.ws, pbonzini@redhat.com,
	eblake@redhat.com, afaerber@suse.de,
	"Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [RFC V3 5/9] quorum: Add quorum_aio_writev and its dependencies.
Date: Tue, 14 Aug 2012 16:14:07 +0200	[thread overview]
Message-ID: <1344953651-16622-6-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1344953651-16622-1-git-send-email-benoit@irqsave.net>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block/quorum.c |  112 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 112 insertions(+)

diff --git a/block/quorum.c b/block/quorum.c
index a3f16ed..0a6647f 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -169,6 +169,116 @@ static int64_t quorum_getlength(BlockDriverState *bs)
     return bdrv_getlength(s->bs[0]);
 }
 
+static void quorum_aio_cancel(BlockDriverAIOCB *blockacb)
+{
+    QuorumAIOCB *acb = container_of(blockacb, QuorumAIOCB, common);
+    bool finished = false;
+
+    /* Wait for the request to finish */
+    acb->finished = &finished;
+    while (!finished) {
+        qemu_aio_wait();
+    }
+}
+
+static AIOPool quorum_aio_pool = {
+    .aiocb_size         = sizeof(QuorumAIOCB),
+    .cancel             = quorum_aio_cancel,
+};
+
+static void quorum_aio_bh(void *opaque)
+{
+    QuorumAIOCB *acb = opaque;
+    BDRVQuorumState *s = acb->bqs;
+    int ret;
+
+    ret = s->n <= acb->success_count ? 0 : -EIO;
+
+    qemu_bh_delete(acb->bh);
+    acb->common.cb(acb->common.opaque, ret);
+    if (acb->finished) {
+        *acb->finished = true;
+    }
+    g_free(acb->aios);
+    g_free(acb->qiovs);
+    qemu_aio_release(acb);
+}
+
+static QuorumAIOCB *quorum_aio_get(BDRVQuorumState *s,
+                                   BlockDriverState *bs,
+                                   QEMUIOVector *qiov,
+                                   int64_t sector_num,
+                                   int nb_sectors,
+                                   BlockDriverCompletionFunc *cb,
+                                   void *opaque)
+{
+    QuorumAIOCB *acb = qemu_aio_get(&quorum_aio_pool, bs, cb, opaque);
+    int i;
+
+    acb->aios = g_new0(QuorumSingleAIOCB, s->m);
+    acb->qiovs = g_new0(QEMUIOVector, s->m);
+
+    acb->bqs = s;
+    acb->qiov = qiov;
+    acb->bh = NULL;
+    acb->count = 0;
+    acb->success_count = 0;
+    acb->sector_num = sector_num;
+    acb->nb_sectors = nb_sectors;
+    acb->vote = NULL;
+    acb->vote_ret = 0;
+
+    for (i = 0; i < s->m; i++) {
+        acb->aios[i].buf = NULL;
+        acb->aios[i].ret = 0;
+        acb->aios[i].parent = acb;
+    }
+
+    return acb;
+}
+
+static void quorum_aio_cb(void *opaque, int ret)
+{
+    QuorumSingleAIOCB *sacb = opaque;
+    QuorumAIOCB *acb = sacb->parent;
+    BDRVQuorumState *s = acb->bqs;
+
+    sacb->ret = ret;
+    acb->count++;
+    if (ret == 0) {
+        acb->success_count += 1;
+    }
+    assert(acb->count <= s->m);
+    assert(acb->success_count <= s->m);
+    if (acb->count < s->m) {
+        return;
+    }
+
+    acb->bh = qemu_bh_new(quorum_aio_bh, acb);
+    qemu_bh_schedule(acb->bh);
+}
+
+static BlockDriverAIOCB *quorum_aio_writev(BlockDriverState *bs,
+                                          int64_t sector_num,
+                                          QEMUIOVector *qiov,
+                                          int nb_sectors,
+                                          BlockDriverCompletionFunc *cb,
+                                          void *opaque)
+{
+    BDRVQuorumState *s = bs->opaque;
+    QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num, nb_sectors,
+                                      cb, opaque);
+    int i;
+
+    for (i = 0; i < s->m; i++) {
+        acb->aios[i].aiocb = bdrv_aio_writev(s->bs[i], sector_num, qiov,
+                                             nb_sectors, &quorum_aio_cb,
+                                             &acb->aios[i]);
+    }
+
+    return &acb->common;
+}
+
 static BlockDriver bdrv_quorum = {
     .format_name        = "quorum",
     .protocol_name      = "quorum",
@@ -179,6 +289,8 @@ static BlockDriver bdrv_quorum = {
 
     .bdrv_file_open     = quorum_open,
     .bdrv_close         = quorum_close,
+
+    .bdrv_aio_writev    = quorum_aio_writev,
 };
 
 static void bdrv_quorum_init(void)
-- 
1.7.9.5

  parent reply	other threads:[~2012-08-14 14:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 14:14 [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close() Benoît Canet
2012-08-14 14:45   ` Eric Blake
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength() Benoît Canet
2012-08-14 16:08   ` Eric Blake
2012-08-16 13:18     ` Benoît Canet
2012-08-14 14:14 ` Benoît Canet [this message]
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 6/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush() Benoît Canet
2012-08-14 18:52   ` Blue Swirl
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv Benoît Canet
2012-08-15 10:53   ` Stefan Hajnoczi
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism Benoît Canet
2012-08-15 10:51   ` Stefan Hajnoczi
2012-08-14 18:47 ` [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Blue Swirl
2012-08-15 13:12 ` Stefan Hajnoczi
2012-08-20 10:12 ` Benoît Canet
2012-08-20 11:23   ` Stefan Hajnoczi
2012-08-20 11:24     ` Stefan Hajnoczi
2012-08-20 11:42       ` Benoît Canet
2012-08-20 12:56         ` Stefan Hajnoczi
2012-08-20 14:03           ` Benoît Canet
2012-08-20 15:28             ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344953651-16622-6-git-send-email-benoit@irqsave.net \
    --to=benoit.canet@gmail.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=benoit@irqsave.net \
    --cc=blauwirbel@gmail.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).