From: TeLeMan <geleman@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH]bug fix for softmmu slow_st unaligned access
Date: Sat, 27 Oct 2007 21:00:13 -0700 (PDT) [thread overview]
Message-ID: <13449885.post@talk.nabble.com> (raw)
For example, the memory address 0x10008000 is on an unwritable page.When the
instruction "add dword ptr [0x10007FFF],0x12345678" is executed,the OS will
set 0x10008000 page be a writable page and re-execute this instruction. But
softmmu has modifed the value of 0x10007FFF,so after re-executing this
instruction, the final result is wrong(double-added on 0x10007FFF).
Reversing the stored byte order can fix this bug.
softmmu.patch:
*** qemu.orig/softmmu_template.h Sun Oct 28 11:15:52 2007
--- qemu/softmmu_template.h Sun Oct 28 11:22:24 2007
*************** static void glue(glue(slow_st, SUFFIX),
*** 282,288 ****
} else if (((addr & ~TARGET_PAGE_MASK) + DATA_SIZE - 1) >=
TARGET_PAGE_SIZE) {
do_unaligned_access:
/* XXX: not efficient, but simple */
! for(i = 0;i < DATA_SIZE; i++) {
#ifdef TARGET_WORDS_BIGENDIAN
glue(slow_stb, MMUSUFFIX)(addr + i, val >> (((DATA_SIZE -
1) * 8) - (i * 8)),
mmu_idx, retaddr);
--- 282,288 ----
} else if (((addr & ~TARGET_PAGE_MASK) + DATA_SIZE - 1) >=
TARGET_PAGE_SIZE) {
do_unaligned_access:
/* XXX: not efficient, but simple */
! for(i = DATA_SIZE-1;i >= 0; i--) {
#ifdef TARGET_WORDS_BIGENDIAN
glue(slow_stb, MMUSUFFIX)(addr + i, val >> (((DATA_SIZE -
1) * 8) - (i * 8)),
mmu_idx, retaddr);
http://www.nabble.com/file/p13449885/softmmu.patch softmmu.patch
--
View this message in context: http://www.nabble.com/-PATCH-bug-fix-for-softmmu-slow_st-unaligned-access-tf4705397.html#a13449885
Sent from the QEMU - Dev mailing list archive at Nabble.com.
next reply other threads:[~2007-10-28 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 4:00 TeLeMan [this message]
2007-10-31 2:16 ` [Qemu-devel] [PATCH]bug fix for softmmu slow_st unaligned access andrzej zaborowski
2007-10-31 2:59 ` TeLeMan
2007-11-17 9:54 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13449885.post@talk.nabble.com \
--to=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).