From: Alexander Graf <agraf@suse.de>
To: qemu-ppc Mailing List <qemu-ppc@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 02/24] pseries pci: spapr_populate_pci_devices renamed to spapr_populate_pci_dt
Date: Wed, 15 Aug 2012 11:58:40 +0200 [thread overview]
Message-ID: <1345024742-18394-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1345024742-18394-1-git-send-email-agraf@suse.de>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
spapr_populate_pci_devices() populates the device tree only with bus
properties and has nothing to do with the devices on it as PCI BAR
allocation is done by the system firmware (SLOF).
New name - spapr_populate_pci_dt() - describes the functionality better.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/spapr.c | 2 +-
hw/spapr_pci.c | 6 +++---
hw/spapr_pci.h | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/spapr.c b/hw/spapr.c
index 81c9343..ab5a0c2 100644
--- a/hw/spapr.c
+++ b/hw/spapr.c
@@ -481,7 +481,7 @@ static void spapr_finalize_fdt(sPAPREnvironment *spapr,
}
QLIST_FOREACH(phb, &spapr->phbs, list) {
- ret = spapr_populate_pci_devices(phb, PHANDLE_XICP, fdt);
+ ret = spapr_populate_pci_dt(phb, PHANDLE_XICP, fdt);
}
if (ret < 0) {
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index 5bee180..2913540 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -406,9 +406,9 @@ void spapr_create_phb(sPAPREnvironment *spapr,
#define b_fff(x) b_x((x), 8, 3) /* function number */
#define b_rrrrrrrr(x) b_x((x), 0, 8) /* register number */
-int spapr_populate_pci_devices(sPAPRPHBState *phb,
- uint32_t xics_phandle,
- void *fdt)
+int spapr_populate_pci_dt(sPAPRPHBState *phb,
+ uint32_t xics_phandle,
+ void *fdt)
{
int bus_off, i, j;
char nodename[256];
diff --git a/hw/spapr_pci.h b/hw/spapr_pci.h
index a141764..dd66f4b 100644
--- a/hw/spapr_pci.h
+++ b/hw/spapr_pci.h
@@ -55,8 +55,8 @@ void spapr_create_phb(sPAPREnvironment *spapr,
uint64_t mem_win_addr, uint64_t mem_win_size,
uint64_t io_win_addr);
-int spapr_populate_pci_devices(sPAPRPHBState *phb,
- uint32_t xics_phandle,
- void *fdt);
+int spapr_populate_pci_dt(sPAPRPHBState *phb,
+ uint32_t xics_phandle,
+ void *fdt);
#endif /* __HW_SPAPR_PCI_H__ */
--
1.6.0.2
next prev parent reply other threads:[~2012-08-15 9:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 9:58 [Qemu-devel] [PULL 00/24] ppc patch queue 2012-08-15 Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 01/24] pseries pci: removed redundant busdev Alexander Graf
2012-08-15 10:17 ` Andreas Färber
2012-08-15 9:58 ` Alexander Graf [this message]
2012-08-15 9:58 ` [Qemu-devel] [PATCH 03/24] PPC: e500: rename mpc8544ds into generic file Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 04/24] PPC: e500: change internal references away from mpc8544ds Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 05/24] PPC: e500: split mpc8544ds machine from generic e500 code Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 06/24] PPC: e500: add generic e500 platform Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 07/24] ppc: Fix bug in handling of PAPR hypercall exits Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 08/24] Revert "PPC: e500: Use new MPIC dt format" Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 09/24] Add one new file vga-pci.h and cleanup on all platforms Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 10/24] spapr: Add support for -vga option Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 11/24] xbzrle: fix compilation on ppc32 Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 12/24] PPC: spapr: Rework VGA select logic Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 13/24] PPC: spapr: Remove global variable Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 14/24] pseries: Update SLOF Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 15/24] pseries: Remove extraneous prints Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 16/24] pseries: Rework irq assignment to avoid carrying qemu_irqs around Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 17/24] pseries: Separate PCI RTAS setup from common from emulation specific PCI setup Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 18/24] pseries: added allocator for a block of IRQs Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 19/24] pseries: Export find_phb() utility function for PCI code Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 20/24] pseries: Add trace event for PCI irqs Alexander Graf
2012-08-15 9:58 ` [Qemu-devel] [PATCH 21/24] pseries: Add PCI MSI/MSI-X support Alexander Graf
2012-08-15 17:19 ` Andreas Färber
2012-08-15 17:46 ` Alexander Graf
2012-08-15 9:59 ` [Qemu-devel] [PATCH 22/24] pseries dma: DMA window params added to PHB and DT population changed Alexander Graf
2012-08-15 9:59 ` [Qemu-devel] [PATCH 23/24] pseries: Update SLOF firmware image Alexander Graf
2012-08-15 9:59 ` [Qemu-devel] [PATCH 24/24] openpic: Added BRR1 register Alexander Graf
2012-08-15 21:14 ` [Qemu-devel] [PULL 00/24] ppc patch queue 2012-08-15 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345024742-18394-3-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).