From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Alberto Garcia <agarcia@igalia.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 9/9] ivshmem, qdev-monitor: fix order of qerror parameters
Date: Wed, 15 Aug 2012 16:09:04 +0100 [thread overview]
Message-ID: <1345043344-3978-10-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1345043344-3978-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Alberto Garcia <agarcia@igalia.com>
Now that the QERR_ macros no longer contain a json dictionary,
the order of some parameters needs to be fixed for them to appear
correctly.
Signed-off-by: Alberto Garcia <agarcia@igalia.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
hw/ivshmem.c | 3 ++-
hw/qdev-monitor.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index 0c58161..b4d65a6 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -677,7 +677,8 @@ static int pci_ivshmem_init(PCIDevice *dev)
}
if (s->role_val == IVSHMEM_PEER) {
- error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION, "ivshmem", "peer mode");
+ error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION,
+ "peer mode", "ivshmem");
migrate_add_blocker(s->migration_blocker);
}
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index b22a37a..018b386 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -443,7 +443,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
bus = qbus_find_recursive(sysbus_get_default(), NULL, k->bus_type);
if (!bus) {
qerror_report(QERR_NO_BUS_FOR_DEVICE,
- driver, k->bus_type);
+ k->bus_type, driver);
return NULL;
}
}
--
1.7.10.4
next prev parent reply other threads:[~2012-08-15 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 15:08 [Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012 Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 1/9] Makefile: Avoid explicit list of directories in clean target Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 2/9] ehci: fix assertion typo Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 3/9] cputlb.c: Fix out of date comment Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 4/9] trace: Fix "Qemu" -> "QEMU" Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 5/9] docs: Fix spelling (propery -> property) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 6/9] Spelling fix in comment (peripherans -> peripherals) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 7/9] framebuffer: Fix spelling in comment (leight -> height) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 8/9] iov_send_recv(): Handle zero bytes case even if OS does not Stefan Hajnoczi
2012-08-15 15:09 ` Stefan Hajnoczi [this message]
2012-08-15 19:48 ` [Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345043344-3978-10-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=agarcia@igalia.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).