qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/9] cputlb.c: Fix out of date comment
Date: Wed, 15 Aug 2012 16:08:58 +0100	[thread overview]
Message-ID: <1345043344-3978-4-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1345043344-3978-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Peter Maydell <peter.maydell@linaro.org>

The comment about the return address from get_page_addr_code() was
well out of date as phys_ram_base has not existed for some time.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 cputlb.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cputlb.c b/cputlb.c
index 0d1e252..d3e7b25 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -312,7 +312,9 @@ void tlb_set_page(CPUArchState *env, target_ulong vaddr,
 
 /* NOTE: this function can trigger an exception */
 /* NOTE2: the returned address is not exactly the physical address: it
-   is the offset relative to phys_ram_base */
+ * is actually a ram_addr_t (in system mode; the user mode emulation
+ * version of this function returns a guest virtual address).
+ */
 tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr)
 {
     int mmu_idx, page_index, pd;
-- 
1.7.10.4

  parent reply	other threads:[~2012-08-15 15:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 15:08 [Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012 Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 1/9] Makefile: Avoid explicit list of directories in clean target Stefan Hajnoczi
2012-08-15 15:08 ` [Qemu-devel] [PATCH 2/9] ehci: fix assertion typo Stefan Hajnoczi
2012-08-15 15:08 ` Stefan Hajnoczi [this message]
2012-08-15 15:08 ` [Qemu-devel] [PATCH 4/9] trace: Fix "Qemu" -> "QEMU" Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 5/9] docs: Fix spelling (propery -> property) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 6/9] Spelling fix in comment (peripherans -> peripherals) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 7/9] framebuffer: Fix spelling in comment (leight -> height) Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 8/9] iov_send_recv(): Handle zero bytes case even if OS does not Stefan Hajnoczi
2012-08-15 15:09 ` [Qemu-devel] [PATCH 9/9] ivshmem, qdev-monitor: fix order of qerror parameters Stefan Hajnoczi
2012-08-15 19:48 ` [Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345043344-3978-4-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).