qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
	gleb@redhat.com, vijaymohan.pandarathil@hp.com,
	jan.kiszka@siemens.com, mtosatti@redhat.com,
	mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
	pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com,
	afaerber@suse.de, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 03/21] target-i386: if x86_cpu_realize() failed report error and do cleanup
Date: Wed, 15 Aug 2012 18:13:23 +0200	[thread overview]
Message-ID: <1345047221-26898-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1345047221-26898-1-git-send-email-imammedo@redhat.com>

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Andreas Färber <afaerber@suse.de>
---
 target-i386/helper.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/target-i386/helper.c b/target-i386/helper.c
index 8a5da3d..a0e4c89 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1151,6 +1151,7 @@ X86CPU *cpu_x86_init(const char *cpu_model)
 {
     X86CPU *cpu;
     CPUX86State *env;
+    Error *error = NULL;
 
     cpu = X86_CPU(object_new(TYPE_X86_CPU));
     env = &cpu->env;
@@ -1161,8 +1162,12 @@ X86CPU *cpu_x86_init(const char *cpu_model)
         return NULL;
     }
 
-    x86_cpu_realize(OBJECT(cpu), NULL);
-
+    x86_cpu_realize(OBJECT(cpu), &error);
+    if (error_is_set(&error)) {
+        error_free(error);
+        object_delete(OBJECT(cpu));
+        return NULL;
+    }
     return cpu;
 }
 
-- 
1.7.11.2

  parent reply	other threads:[~2012-08-15 16:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 16:13 [Qemu-devel] [PATCH 00/21] target-i386: convert CPU features into properties Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 01/21] target-i386: return Error from cpu_x86_find_by_name() Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 02/21] target-i386: cpu_x86_register(): report error from property setter Igor Mammedov
2012-08-15 16:13 ` Igor Mammedov [this message]
2012-08-15 16:13 ` [Qemu-devel] [PATCH 04/21] target-i386: filter out not TCG features if running without kvm at realize time Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 05/21] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 06/21] target-i386: xlevel should be more than 0x80000000, move fixup into setter Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 07/21] target-i386: convert cpuid features into properties Igor Mammedov
2012-08-16 18:10   ` Eduardo Habkost
2012-08-17 17:32     ` Eduardo Habkost
2012-08-20 12:16     ` Igor Mammedov
2012-08-20 12:34       ` Eduardo Habkost
2012-08-15 16:13 ` [Qemu-devel] [PATCH 08/21] target-i386: convert 'hv_spinlocks' feature into property Igor Mammedov
2012-08-15 20:43   ` Eduardo Habkost
2012-08-15 21:32     ` Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 09/21] target-i386: convert 'hv_relaxed' " Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 10/21] target-i386: convert 'hv_vapic' " Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 11/21] target-i386: convert 'check' and 'enforce' features into properties Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 12/21] add visitor for parsing hz[KMG] input string Igor Mammedov
2012-08-15 16:44   ` Andreas Färber
2012-08-15 17:08     ` Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 13/21] target-i386: use visit_type_hz to parse tsc_freq property value Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 14/21] target-i386: introduce vendor-override property Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 15/21] target-i386: use define for cpuid vendor string size Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 16/21] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 17/21] target-i386: parse cpu_model string into set of stringified properties Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 18/21] target-i386: use properties to set/unset user specified features on CPU Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 19/21] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 20/21] target-i386: move default init of cpuid_kvm_features bitmap " Igor Mammedov
2012-08-15 16:13 ` [Qemu-devel] [PATCH 21/21] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it Igor Mammedov
2012-08-16  3:02 ` [Qemu-devel] [PATCH 00/21] target-i386: convert CPU features into properties Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345047221-26898-4-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=lersek@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).