qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
	gleb@redhat.com, vijaymohan.pandarathil@hp.com,
	jan.kiszka@siemens.com, mtosatti@redhat.com,
	mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
	pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com,
	afaerber@suse.de
Subject: [Qemu-devel] [RFC 07/13] cpu_x86_create: move error handling to end of function
Date: Thu, 16 Aug 2012 13:59:06 -0300	[thread overview]
Message-ID: <1345136352-10756-8-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1345136352-10756-1-git-send-email-ehabkost@redhat.com>

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index da7b5af..0bf62da 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1544,12 +1544,14 @@ X86CPU *cpu_x86_create(const char *cpu_model)
     env->cpu_model_str = cpu_model;
 
     if (cpu_x86_register(cpu, cpu_model) < 0) {
-        object_delete(OBJECT(cpu));
-        return NULL;
+        goto error;
     }
 
     x86_cpu_realize(OBJECT(cpu), NULL);
     return cpu;
+error:
+    object_delete(OBJECT(cpu));
+    return NULL;
 }
 
 #if !defined(CONFIG_USER_ONLY)
-- 
1.7.11.2

  parent reply	other threads:[~2012-08-16 18:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 16:58 [Qemu-devel] [RFC 00/13] CPU init cleanup + CPU model classes (v2) Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 01/13] target-i386/cpu.c: coding style fixes Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 02/13] x86_cpudef_setup: coding style change Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 03/13] i386: x86_def_t: rename 'flags' field Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 04/13] move CPU x86 object creation to cpu.c Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 05/13] rename x86_def_t to X86CPUDefinition Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 06/13] move X86CPUDefinition to cpu-qom.h Eduardo Habkost
2012-08-16 16:59 ` Eduardo Habkost [this message]
2012-08-16 16:59 ` [Qemu-devel] [RFC 08/13] cpu_x86_register: always initialize 'name' and 'features' Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 09/13] kill cpu_x86_register() Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 10/13] cpu_x86_create: reorder parsing of CPU model string and creation of CPU object Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 11/13] check for NULL cpu_model outside cpu_x86_find_by_name Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 12/13] register a class for each CPU model (v2) Eduardo Habkost
2012-08-16 16:59 ` [Qemu-devel] [RFC 13/13] HACK to initialize types later Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345136352-10756-8-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=lersek@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).