From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2L4v-0001Av-KJ for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2L4u-0002vm-MB for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:51:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2L4u-0002vc-EO for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:51:00 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7HBox39003258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Aug 2012 07:50:59 -0400 From: Alon Levy Date: Fri, 17 Aug 2012 14:50:50 +0300 Message-Id: <1345204252-8205-3-git-send-email-alevy@redhat.com> In-Reply-To: <1345204252-8205-1-git-send-email-alevy@redhat.com> References: <1345204252-8205-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com Signed-off-by: Alon Levy --- hw/qxl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break; case 3: /* qxl-3 */ - default: pci_device_rev = QXL_DEFAULT_REVISION; io_size = msb_mask(QXL_IO_RANGE_SIZE * 2 - 1); break; + default: + error_report("Invalid revision %d for qxl device (max %d)", + qxl->revision, QXL_DEFAULT_REVISION); + return -1; } pci_set_byte(&config[PCI_REVISION_ID], pci_device_rev); -- 1.7.11.2