From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2Mgh-0004yg-UV for qemu-devel@nongnu.org; Fri, 17 Aug 2012 09:34:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2Mgg-0003ba-VT for qemu-devel@nongnu.org; Fri, 17 Aug 2012 09:34:07 -0400 From: Stefan Weil Date: Fri, 17 Aug 2012 15:34:04 +0200 Message-Id: <1345210444-2292-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] monitor: Fix warning from clang List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: qemu-devel@nongnu.org, Stefan Weil , Markus Armbruster , Luiz Capitulino ccc-analyzer reports these warnings: monitor.c:3532:21: warning: Division by zero val %= val2; ^ monitor.c:3530:21: warning: Division by zero val /= val2; ^ Rewriting the code fixes this (and also a style issue). Signed-off-by: Stefan Weil --- monitor.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 0c34934..0ea2c14 100644 --- a/monitor.c +++ b/monitor.c @@ -3524,12 +3524,13 @@ static int64_t expr_prod(Monitor *mon) break; case '/': case '%': - if (val2 == 0) + if (val2 == 0) { expr_error(mon, "division by zero"); - if (op == '/') + } else if (op == '/') { val /= val2; - else + } else { val %= val2; + } break; } } -- 1.7.10