From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com,
mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com,
afaerber@suse.de
Subject: [Qemu-devel] [RFC 1/6] x86_cpudef_setup: coding style change
Date: Fri, 17 Aug 2012 14:53:37 -0300 [thread overview]
Message-ID: <1345226022-21654-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1345226022-21654-1-git-send-email-ehabkost@redhat.com>
Make source code lines shorter.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 96ec9e6..519a104 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1500,20 +1500,23 @@ void x86_cpudef_setup(void)
static const char *model_with_versions[] = { "qemu32", "qemu64", "athlon" };
for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) {
- builtin_x86_defs[i].next = x86_defs;
- builtin_x86_defs[i].flags = 1;
+ x86_def_t *def = &builtin_x86_defs[i];
+ def->next = x86_defs;
+ def->flags = 1;
/* Look for specific "cpudef" models that */
/* have the QEMU version in .model_id */
for (j = 0; j < ARRAY_SIZE(model_with_versions); j++) {
- if (strcmp(model_with_versions[j], builtin_x86_defs[i].name) == 0) {
- pstrcpy(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), "QEMU Virtual CPU version ");
- pstrcat(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), qemu_get_version());
+ if (strcmp(model_with_versions[j], def->name) == 0) {
+ pstrcpy(def->model_id, sizeof(def->model_id),
+ "QEMU Virtual CPU version ");
+ pstrcat(def->model_id, sizeof(def->model_id),
+ qemu_get_version());
break;
}
}
- x86_defs = &builtin_x86_defs[i];
+ x86_defs = def;
}
#if !defined(CONFIG_USER_ONLY)
qemu_opts_foreach(qemu_find_opts("cpudef"), cpudef_register, NULL, 0);
--
1.7.11.2
next prev parent reply other threads:[~2012-08-17 17:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 17:53 [Qemu-devel] [RFC 0/6] i386: CPU: remove duplicate feature names Eduardo Habkost
2012-08-17 17:53 ` Eduardo Habkost [this message]
2012-09-05 8:44 ` [Qemu-devel] [RFC 1/6] x86_cpudef_setup: coding style change Igor Mammedov
2012-08-17 17:53 ` [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support Eduardo Habkost
2012-08-20 10:51 ` Andreas Färber
2012-08-20 12:00 ` Igor Mammedov
2012-08-20 12:30 ` Eduardo Habkost
2012-09-05 9:09 ` Igor Mammedov
2012-09-05 9:39 ` Igor Mammedov
2012-09-06 17:55 ` Eduardo Habkost
2012-08-17 17:53 ` [Qemu-devel] [RFC 3/6] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved Eduardo Habkost
2012-09-05 8:48 ` Igor Mammedov
2012-08-17 17:53 ` [Qemu-devel] [RFC 4/6] i386: kvm: use a #define for the set of alias feature bits Eduardo Habkost
2012-09-05 8:53 ` Igor Mammedov
2012-08-17 17:53 ` [Qemu-devel] [RFC 5/6] i386: cpu: eliminate duplicate feature names Eduardo Habkost
2012-08-17 17:53 ` [Qemu-devel] [RFC 6/6] i386: -cpu help: remove reference to specific CPUID leaves/registers Eduardo Habkost
2012-09-05 11:47 ` Igor Mammedov
2012-08-20 12:02 ` [Qemu-devel] [RFC 0/6] i386: CPU: remove duplicate feature names Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345226022-21654-2-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).