qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail
Date: Sat, 18 Aug 2012 13:17:08 +0200	[thread overview]
Message-ID: <1345288635-1369-2-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1345288635-1369-1-git-send-email-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 buffered_file.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/buffered_file.c b/buffered_file.c
index f170aa0..4148abb 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -50,20 +50,12 @@ static void buffered_append(QEMUFileBuffered *s,
                             const uint8_t *buf, size_t size)
 {
     if (size > (s->buffer_capacity - s->buffer_size)) {
-        void *tmp;
-
         DPRINTF("increasing buffer capacity from %zu by %zu\n",
                 s->buffer_capacity, size + 1024);

         s->buffer_capacity += size + 1024;

-        tmp = g_realloc(s->buffer, s->buffer_capacity);
-        if (tmp == NULL) {
-            fprintf(stderr, "qemu file buffer expansion failed\n");
-            exit(1);
-        }
-
-        s->buffer = tmp;
+        s->buffer = g_realloc(s->buffer, s->buffer_capacity);
     }

     memcpy(s->buffer + s->buffer_size, buf, size);
-- 
1.7.11.2

  reply	other threads:[~2012-08-18 11:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18 11:17 [Qemu-devel] [PATCH v2 0/8] Migration stats Juan Quintela
2012-08-18 11:17 ` Juan Quintela [this message]
2012-08-21 10:40   ` [Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 2/8] fix migration sync Juan Quintela
2012-08-21 10:52   ` Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 3/8] migration: move total_time from ram stats to migration info Juan Quintela
2012-08-18 13:02   ` [Qemu-devel] For 1.2: " Eric Blake
2012-08-21 14:42     ` Luiz Capitulino
2012-08-21 15:00       ` Juan Quintela
2012-08-21 18:24         ` Luiz Capitulino
2012-08-22 13:22     ` Anthony Liguori
2012-08-22 14:48       ` Eric Blake
2012-08-21 10:53   ` [Qemu-devel] " Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 4/8] migration: store end_time in a local variable Juan Quintela
2012-08-18 11:17 ` [Qemu-devel] [PATCH 5/8] migration: print total downtime for final phase of migration Juan Quintela
2012-08-18 13:04   ` Eric Blake
2012-08-21 10:57   ` Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime Juan Quintela
2012-08-21 10:57   ` Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 7/8] migration: export migrate_get_current() Juan Quintela
2012-08-21 10:58   ` Orit Wasserman
2012-08-18 11:17 ` [Qemu-devel] [PATCH 8/8] migration: print expected downtime in info migrate Juan Quintela
2012-08-18 13:05   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345288635-1369-2-git-send-email-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).