From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org, s.priebe@profihost.ag
Cc: ronniesahlberg@gmail.com
Subject: [Qemu-devel] [PATCH 1/3] iscsi: move iscsi_schedule_bh and iscsi_readv_writev_bh_cb
Date: Sat, 18 Aug 2012 23:49:01 +0200 [thread overview]
Message-ID: <1345326543-10677-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1345326543-10677-1-git-send-email-pbonzini@redhat.com>
Put these functions at the beginning, to avoid forward references
in the next patches.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 56 ++++++++++++++++++++++++++++----------------------------
1 file modificato, 28 inserzioni(+), 28 rimozioni(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 993a86d..7cfd752 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -73,6 +73,34 @@ struct IscsiTask {
};
static void
+iscsi_readv_writev_bh_cb(void *p)
+{
+ IscsiAIOCB *acb = p;
+
+ qemu_bh_delete(acb->bh);
+
+ if (acb->canceled == 0) {
+ acb->common.cb(acb->common.opaque, acb->status);
+ }
+
+ qemu_aio_release(acb);
+}
+
+static int
+iscsi_schedule_bh(QEMUBHFunc *cb, IscsiAIOCB *acb)
+{
+ acb->bh = qemu_bh_new(cb, acb);
+ if (!acb->bh) {
+ error_report("oom: could not create iscsi bh");
+ return -EIO;
+ }
+
+ qemu_bh_schedule(acb->bh);
+ return 0;
+}
+
+
+static void
iscsi_abort_task_cb(struct iscsi_context *iscsi, int status, void *command_data,
void *private_data)
{
@@ -159,34 +187,6 @@ iscsi_process_write(void *arg)
}
-static int
-iscsi_schedule_bh(QEMUBHFunc *cb, IscsiAIOCB *acb)
-{
- acb->bh = qemu_bh_new(cb, acb);
- if (!acb->bh) {
- error_report("oom: could not create iscsi bh");
- return -EIO;
- }
-
- qemu_bh_schedule(acb->bh);
- return 0;
-}
-
-static void
-iscsi_readv_writev_bh_cb(void *p)
-{
- IscsiAIOCB *acb = p;
-
- qemu_bh_delete(acb->bh);
-
- if (acb->canceled == 0) {
- acb->common.cb(acb->common.opaque, acb->status);
- }
-
- qemu_aio_release(acb);
-}
-
-
static void
iscsi_aio_write16_cb(struct iscsi_context *iscsi, int status,
void *command_data, void *opaque)
--
1.7.11.2
next prev parent reply other threads:[~2012-08-18 21:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 21:49 [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort Paolo Bonzini
2012-08-18 21:49 ` Paolo Bonzini [this message]
2012-08-18 21:49 ` [Qemu-devel] [PATCH 2/3] iscsi: simplify iscsi_schedule_bh Paolo Bonzini
2012-08-18 21:49 ` [Qemu-devel] [PATCH 3/3] iscsi: fix races between task completion and abort Paolo Bonzini
2012-08-19 7:55 ` [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / " Stefan Priebe
2012-08-19 13:11 ` Paolo Bonzini
2012-08-19 19:22 ` Stefan Priebe - Profihost AG
2012-08-20 7:22 ` Paolo Bonzini
2012-08-20 7:34 ` Stefan Priebe - Profihost AG
2012-08-20 8:08 ` Paolo Bonzini
2012-08-20 8:12 ` Stefan Priebe - Profihost AG
2012-08-20 22:36 ` ronnie sahlberg
2012-08-21 7:22 ` Stefan Priebe - Profihost AG
2012-08-21 7:30 ` Paolo Bonzini
2012-11-06 8:41 ` [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands Stefan Priebe - Profihost AG
2012-11-06 22:42 ` Paolo Bonzini
2012-11-07 18:57 ` Stefan Priebe
2012-11-18 22:00 ` Stefan Priebe
2012-11-19 8:10 ` Paolo Bonzini
2012-11-19 9:36 ` Stefan Priebe - Profihost AG
2012-11-19 9:54 ` Paolo Bonzini
2012-11-19 9:59 ` Stefan Priebe - Profihost AG
2012-11-19 10:06 ` Paolo Bonzini
2012-11-19 10:13 ` Stefan Priebe - Profihost AG
2012-11-19 10:23 ` Paolo Bonzini
2012-11-19 10:30 ` Stefan Priebe - Profihost AG
2012-11-19 10:36 ` Paolo Bonzini
2012-11-19 10:57 ` Stefan Priebe - Profihost AG
2012-11-19 11:16 ` Paolo Bonzini
2012-11-19 11:49 ` Stefan Priebe - Profihost AG
2012-11-19 12:24 ` Paolo Bonzini
2012-11-19 13:01 ` Stefan Priebe - Profihost AG
2012-11-19 13:06 ` Paolo Bonzini
2012-11-19 14:16 ` Stefan Priebe - Profihost AG
2012-11-19 14:32 ` Paolo Bonzini
2012-11-19 14:28 ` Stefan Priebe - Profihost AG
2012-11-19 14:41 ` Paolo Bonzini
2012-11-19 14:48 ` Stefan Priebe - Profihost AG
2012-11-19 15:03 ` Paolo Bonzini
2012-11-19 15:04 ` Stefan Priebe - Profihost AG
2012-11-19 15:22 ` Paolo Bonzini
2012-11-19 15:58 ` Stefan Priebe - Profihost AG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345326543-10677-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).