From: Brendan Fennell <bfennell@skynet.ie>
To: qemu-devel@nongnu.org, bfennell@skynet.ieqemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR
Date: Sun, 19 Aug 2012 11:59:10 +0100 [thread overview]
Message-ID: <1345373950-16276-1-git-send-email-bfennell@skynet.ie> (raw)
Signed-off-by: Brendan Fennell <bfennell@skynet.ie>
---
hw/pl190.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/pl190.c b/hw/pl190.c
index cb50afb..eddb531 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -120,7 +120,8 @@ static uint64_t pl190_read(void *opaque, target_phys_addr_t offset,
current priority level to that of the current interrupt. */
for (i = 0; i < s->priority; i++)
{
- if ((s->level | s->soft_level) & s->prio_mask[i])
+ /* Ensure that 'i' is current highest priority interrupt on exit */
+ if ((s->level | s->soft_level) & s->prio_mask[i+1])
break;
}
/* Reading this value with no pending interrupts is undefined.
--
1.7.2.5
next reply other threads:[~2012-08-19 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 10:59 Brendan Fennell [this message]
2012-08-19 13:02 ` [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR Blue Swirl
2012-08-20 14:30 ` Peter Maydell
2012-08-20 17:58 ` Brendan Fennell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345373950-16276-1-git-send-email-bfennell@skynet.ie \
--to=bfennell@skynet.ie \
--cc=bfennell@skynet.ieqemu-devel \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).