From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, eblake@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi
Date: Mon, 20 Aug 2012 12:39:23 +0800 [thread overview]
Message-ID: <1345437569-13862-1-git-send-email-akong@redhat.com> (raw)
This series converted 'sendkey' command to qapi. The raw value
in hexadecimal format is not supported by 'send-key' of qmp.
Amos Kong (6):
fix doc of using raw values with sendkey
monitor: rename keyname '<' to 'less'
hmp: rename arguments
qapi: generate list struct and visit_list for enum
add the QKeyCode enum and the key_defs table
qapi: convert sendkey
console.h | 5 +
hmp-commands.hx | 10 +-
hmp.c | 55 +++++++++++
hmp.h | 1 +
input.c | 251 +++++++++++++++++++++++++++++++++++++++++++++++++
monitor.c | 245 +-----------------------------------------------
qapi-schema.json | 46 +++++++++
qmp-commands.hx | 28 ++++++
scripts/qapi-types.py | 16 +++-
scripts/qapi-visit.py | 14 +++-
10 files changed, 421 insertions(+), 250 deletions(-)
---
Changes from v1:
- using a JSON array for the key names
- rename new error to 'QERR_OVERFLOW'
- fix command descriptions
- qapi: generate list struct for enum
- add '<' fixing
Changes from v2:
- fix support of raw value in hexadecimal format
- fix bug in processing of '<-x'
- don't generate useless cleanup functions for enum
- introduced two functions for enum in qapi scripts
- fix command description
- drop keys number limitation in sendkey
- drop patch: qerror: add QERR_OVERFLOW
Changes from v3:
- move key_defs[] to console.h
- link mapping tables by enum values
- rename 'sendkey' to 'send-key' for qmp
Changes from v4:
- rename 'KeyCodes' to 'QKeyCode'
- fix default hold-time
- move qmp_send_key(), key_defs to input.c
- duplicate the keylist in qmp_send_key()
- drop struct KeyDef
- handle invalid key/index in hmp_send_key()
Changes from v5:
- split the addition of the QKeyCode enum and the key_defs table
- split help functions definition
- fix cmd completion and make key_defs static
- drop ps2 trival fix, will post it by another thread
Changes from v6:
- split convert patch to two patches, and do the refactorings
in first patch.
next reply other threads:[~2012-08-20 4:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 4:39 Amos Kong [this message]
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 1/6] fix doc of using raw values with sendkey Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 2/6] monitor: rename keyname '<' to 'less' Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 3/6] hmp: rename arguments Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 4/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 5/6] add the QKeyCode enum and the key_defs table Amos Kong
2012-08-30 17:46 ` Luiz Capitulino
2012-08-31 2:44 ` Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 6/6] qapi: convert sendkey Amos Kong
2012-08-20 13:25 ` [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi Eric Blake
2012-08-20 15:08 ` Luiz Capitulino
2012-08-27 7:23 ` Amos Kong
2012-08-27 13:20 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345437569-13862-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).