From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, Amos Kong <akong@redhat.com>,
eblake@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v7 3/6] hmp: rename arguments
Date: Mon, 20 Aug 2012 12:39:26 +0800 [thread overview]
Message-ID: <1345437569-13862-4-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1345437569-13862-1-git-send-email-akong@redhat.com>
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'.
Signed-off-by: Amos Kong <akong@redhat.com>
---
hmp-commands.hx | 2 +-
monitor.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 6a70a9c..bd0c6c9 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -502,7 +502,7 @@ ETEXI
{
.name = "sendkey",
- .args_type = "string:s,hold_time:i?",
+ .args_type = "keys:s,hold-time:i?",
.params = "keys [hold_ms]",
.help = "send keys to the VM (e.g. 'sendkey ctrl-alt-f1', default hold time=100 ms)",
.mhandler.cmd = do_sendkey,
diff --git a/monitor.c b/monitor.c
index 1082a93..e9665d1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1480,9 +1480,9 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
char keyname_buf[16];
char *separator;
int keyname_len, keycode, i;
- const char *string = qdict_get_str(qdict, "string");
- int has_hold_time = qdict_haskey(qdict, "hold_time");
- int hold_time = qdict_get_try_int(qdict, "hold_time", -1);
+ const char *keys = qdict_get_str(qdict, "keys");
+ int has_hold_time = qdict_haskey(qdict, "hold-time");
+ int hold_time = qdict_get_try_int(qdict, "hold-time", -1);
if (nb_pending_keycodes > 0) {
qemu_del_timer(key_timer);
@@ -1492,10 +1492,10 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
hold_time = 100;
i = 0;
while (1) {
- separator = strchr(string, '-');
- keyname_len = separator ? separator - string : strlen(string);
+ separator = strchr(keys, '-');
+ keyname_len = separator ? separator - keys : strlen(keys);
if (keyname_len > 0) {
- pstrcpy(keyname_buf, sizeof(keyname_buf), string);
+ pstrcpy(keyname_buf, sizeof(keyname_buf), keys);
if (keyname_len > sizeof(keyname_buf) - 1) {
monitor_printf(mon, "invalid key: '%s...'\n", keyname_buf);
return;
@@ -1521,7 +1521,7 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
}
if (!separator)
break;
- string = separator + 1;
+ keys = separator + 1;
}
nb_pending_keycodes = i;
/* key down events */
--
1.7.1
next prev parent reply other threads:[~2012-08-20 4:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 4:39 [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 1/6] fix doc of using raw values with sendkey Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 2/6] monitor: rename keyname '<' to 'less' Amos Kong
2012-08-20 4:39 ` Amos Kong [this message]
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 4/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 5/6] add the QKeyCode enum and the key_defs table Amos Kong
2012-08-30 17:46 ` Luiz Capitulino
2012-08-31 2:44 ` Amos Kong
2012-08-20 4:39 ` [Qemu-devel] [PATCH v7 6/6] qapi: convert sendkey Amos Kong
2012-08-20 13:25 ` [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi Eric Blake
2012-08-20 15:08 ` Luiz Capitulino
2012-08-27 7:23 ` Amos Kong
2012-08-27 13:20 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345437569-13862-4-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).