From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3OMQ-0006gW-U6 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3OMP-0007dd-0n for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:33:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3OMO-0007dP-Ov for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:33:24 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7K9XOuH020906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Aug 2012 05:33:24 -0400 From: Alon Levy Date: Mon, 20 Aug 2012 12:32:36 +0300 Message-Id: <1345455158-15617-2-git-send-email-alevy@redhat.com> In-Reply-To: <1345455158-15617-1-git-send-email-alevy@redhat.com> References: <1345455158-15617-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH v8 2/4] qxl: disallow unknown revisions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com Signed-off-by: Alon Levy --- hw/qxl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break; case 3: /* qxl-3 */ - default: pci_device_rev = QXL_DEFAULT_REVISION; io_size = msb_mask(QXL_IO_RANGE_SIZE * 2 - 1); break; + default: + error_report("Invalid revision %d for qxl device (max %d)", + qxl->revision, QXL_DEFAULT_REVISION); + return -1; } pci_set_byte(&config[PCI_REVISION_ID], pci_device_rev); -- 1.7.11.2