From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size
Date: Mon, 20 Aug 2012 15:31:38 +0100 [thread overview]
Message-ID: <1345473098-26299-1-git-send-email-berrange@redhat.com> (raw)
From: "Daniel P. Berrange" <berrange@redhat.com>
Add a 'query-target' QAPI command to allow management applications
to determine what target architecture a QEMU binary is emulating
without having to parse the binary name or -help output
$ qmp-shell -p /tmp/qemu
(QEMU) query-target
{ u'return': { u'arch': u'x86_64', u'bits': 64}}
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
arch_init.c | 11 +++++++++++
qapi-schema.json | 25 +++++++++++++++++++++++++
qmp-commands.hx | 5 +++++
3 files changed, 41 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index 9b46bfc..095672d 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -1080,3 +1080,14 @@ int xen_available(void)
return 0;
#endif
}
+
+
+TargetInfo *qmp_query_target(Error **errp)
+{
+ TargetInfo *info = g_malloc0(sizeof(*info));
+
+ info->arch = g_strdup(TARGET_ARCH);
+ info->bits = TARGET_PHYS_ADDR_BITS;
+
+ return info;
+}
diff --git a/qapi-schema.json b/qapi-schema.json
index 3d2b2d1..f0e3fe0 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2454,3 +2454,28 @@
#
##
{ 'command': 'query-fdsets', 'returns': ['FdsetInfo'] }
+
+##
+# @TargetInfo:
+#
+# Information describing the QEMU target.
+#
+# @arch: the name of the target architecture (eg "x86_64", "i686", etc)
+#
+# @bits: number of bits in physical address (eg 32 or 64)
+#
+# Since: 1.2.0
+##
+{ 'type': 'TargetInfo',
+ 'data': { 'arch': 'str', 'bits': 'int' } }
+
+##
+# @query-target:
+#
+# Return information about the target for this QEMU
+#
+# Returns: TargetInfo
+#
+# Since: 1.2.0
+##
+{ 'command': 'query-target', 'returns': 'TargetInfo' }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 2ce4ce6..00d798f 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2509,3 +2509,8 @@ EQMP
.mhandler.cmd_new = qmp_marshal_input_query_cpu_definitions,
},
+ {
+ .name = "query-target",
+ .args_type = "",
+ .mhandler.cmd_new = qmp_marshal_input_query_target,
+ },
--
1.7.11.2
next reply other threads:[~2012-08-20 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:31 Daniel P. Berrange [this message]
2012-08-20 15:47 ` [Qemu-devel] For 1.2: Re: [PATCH] qapi: add 'query-target' command to return target arch/bit size Eric Blake
2012-08-20 19:02 ` [Qemu-devel] " Luiz Capitulino
2012-08-21 10:07 ` Daniel P. Berrange
2012-08-21 12:53 ` Luiz Capitulino
2012-08-21 13:07 ` Daniel P. Berrange
2012-08-22 13:20 ` Anthony Liguori
2012-08-20 21:48 ` Anthony Liguori
2012-08-21 10:05 ` Daniel P. Berrange
2012-08-21 10:17 ` Peter Maydell
2012-08-21 10:24 ` Daniel P. Berrange
2012-08-21 13:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345473098-26299-1-git-send-email-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).