* [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection
@ 2012-08-20 18:45 Bruce Rogers
2012-08-20 19:40 ` Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bruce Rogers @ 2012-08-20 18:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Bruce Rogers
When building qemu-kvm for openSUSE:Factory, I am getting a
warning in the pipe2 detection performed by configure, which
prevents using --enable-werror.
Change detection code to use return value of pipe2.
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
configure | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 5808764..2e1f7f8 100755
--- a/configure
+++ b/configure
@@ -2399,8 +2399,7 @@ cat > $TMPC << EOF
int main(void)
{
int pipefd[2];
- pipe2(pipefd, O_CLOEXEC);
- return 0;
+ return pipe2(pipefd, O_CLOEXEC);
}
EOF
if compile_prog "" "" ; then
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection 2012-08-20 18:45 [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection Bruce Rogers @ 2012-08-20 19:40 ` Peter Maydell 2012-10-24 16:48 ` Peter Maydell 2012-10-27 16:52 ` Blue Swirl 2 siblings, 0 replies; 5+ messages in thread From: Peter Maydell @ 2012-08-20 19:40 UTC (permalink / raw) To: Bruce Rogers; +Cc: qemu-devel On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> -- PMM ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection 2012-08-20 18:45 [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection Bruce Rogers 2012-08-20 19:40 ` Peter Maydell @ 2012-10-24 16:48 ` Peter Maydell 2012-10-24 17:20 ` Andreas Färber 2012-10-27 16:52 ` Blue Swirl 2 siblings, 1 reply; 5+ messages in thread From: Peter Maydell @ 2012-10-24 16:48 UTC (permalink / raw) To: Anthony Liguori, Blue Swirl, Aurelien Jarno; +Cc: qemu-devel, Bruce Rogers Ping! Just ran into this bug today and noticed this patch never got applied. Patch still applies OK, patchwork url is: http://patchwork.ozlabs.org/patch/178920/ thanks -- PMM On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> > --- > configure | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 5808764..2e1f7f8 100755 > --- a/configure > +++ b/configure > @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF > int main(void) > { > int pipefd[2]; > - pipe2(pipefd, O_CLOEXEC); > - return 0; > + return pipe2(pipefd, O_CLOEXEC); > } > EOF > if compile_prog "" "" ; then > -- > 1.7.7 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection 2012-10-24 16:48 ` Peter Maydell @ 2012-10-24 17:20 ` Andreas Färber 0 siblings, 0 replies; 5+ messages in thread From: Andreas Färber @ 2012-10-24 17:20 UTC (permalink / raw) To: Peter Maydell Cc: Anthony Liguori, qemu-stable, qemu-devel, Blue Swirl, Bruce Rogers, Aurelien Jarno Am 24.10.2012 18:48, schrieb Peter Maydell: > Ping! Just ran into this bug today and noticed this > patch never got applied. > Patch still applies OK, patchwork url is: > http://patchwork.ozlabs.org/patch/178920/ ...and since it was noticed while packaging v1.2, it should go into stable as well (cc'ed). Andreas > On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: >> When building qemu-kvm for openSUSE:Factory, I am getting a >> warning in the pipe2 detection performed by configure, which >> prevents using --enable-werror. >> >> Change detection code to use return value of pipe2. >> >> Signed-off-by: Bruce Rogers <brogers@suse.com> >> --- >> configure | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 5808764..2e1f7f8 100755 >> --- a/configure >> +++ b/configure >> @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF >> int main(void) >> { >> int pipefd[2]; >> - pipe2(pipefd, O_CLOEXEC); >> - return 0; >> + return pipe2(pipefd, O_CLOEXEC); >> } >> EOF >> if compile_prog "" "" ; then >> -- >> 1.7.7 -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection 2012-08-20 18:45 [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection Bruce Rogers 2012-08-20 19:40 ` Peter Maydell 2012-10-24 16:48 ` Peter Maydell @ 2012-10-27 16:52 ` Blue Swirl 2 siblings, 0 replies; 5+ messages in thread From: Blue Swirl @ 2012-10-27 16:52 UTC (permalink / raw) To: Bruce Rogers; +Cc: qemu-devel Thanks, applied. On Mon, Aug 20, 2012 at 6:45 PM, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> > --- > configure | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 5808764..2e1f7f8 100755 > --- a/configure > +++ b/configure > @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF > int main(void) > { > int pipefd[2]; > - pipe2(pipefd, O_CLOEXEC); > - return 0; > + return pipe2(pipefd, O_CLOEXEC); > } > EOF > if compile_prog "" "" ; then > -- > 1.7.7 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-27 16:53 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-08-20 18:45 [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection Bruce Rogers 2012-08-20 19:40 ` Peter Maydell 2012-10-24 16:48 ` Peter Maydell 2012-10-24 17:20 ` Andreas Färber 2012-10-27 16:52 ` Blue Swirl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).