From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lWP-0004t0-Em for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3lWO-0008UZ-Dc for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lWO-0008UG-5I for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:16 -0400 From: Alon Levy Date: Tue, 21 Aug 2012 13:16:20 +0300 Message-Id: <1345544183-19192-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH v10 1/4] qxl/update_area_io: guest_bug on invalid parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com, blauwirbel@gmail.com Signed-off-by: Alon Levy --- v9->v10 Use CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC instead of -D directly, define is created in config-host.h so hw/qxl.[ch] is unchanged except for s/QXL_HAS_IO_MONITORS_CONFIG_ASYNC/CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC (Blue Swirl) No other patches changed. Dropped the wrongly sent last patch. hw/qxl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6 +1385,18 @@ async_common: QXLCookie *cookie = NULL; QXLRect update = d->ram->update_area; + if (d->ram->update_surface > NUM_SURFACES) { + qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n", + d->ram->update_surface); + return; + } + if (update.left >= update.right || update.top >= update.bottom) { + qxl_set_guest_bug(d, + "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n", + update.left, update.top, update.right, update.bottom); + return; + } + if (async == QXL_ASYNC) { cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, QXL_IO_UPDATE_AREA_ASYNC); -- 1.7.11.2