qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/3] net: EAGAIN handling for net/socket.c UDP
Date: Tue, 21 Aug 2012 16:52:30 +0100	[thread overview]
Message-ID: <1345564351-14693-3-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1345564351-14693-1-git-send-email-stefanha@linux.vnet.ibm.com>

Implement asynchronous send for UDP (or other SOCK_DGRAM) sockets.  If
send fails with EAGAIN we wait for the socket to become writable again.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 net/socket.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index 54e32f0..e5e4e8d 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -102,9 +102,19 @@ static ssize_t net_socket_receive(NetClientState *nc, const uint8_t *buf, size_t
 static ssize_t net_socket_receive_dgram(NetClientState *nc, const uint8_t *buf, size_t size)
 {
     NetSocketState *s = DO_UPCAST(NetSocketState, nc, nc);
+    ssize_t ret;
 
-    return sendto(s->fd, (const void *)buf, size, 0,
-                  (struct sockaddr *)&s->dgram_dst, sizeof(s->dgram_dst));
+    do {
+        ret = sendto(s->fd, buf, size, 0,
+                     (struct sockaddr *)&s->dgram_dst,
+                     sizeof(s->dgram_dst));
+    } while (ret == -1 && errno == EINTR);
+
+    if (ret == -1 && errno == EAGAIN) {
+        net_socket_write_poll(s, true);
+        return 0;
+    }
+    return ret;
 }
 
 static void net_socket_send(void *opaque)
-- 
1.7.10.4

  parent reply	other threads:[~2012-08-21 15:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 15:52 [Qemu-devel] [PATCH v2 0/3] net: asynchronous send/receive for net/socket.c Stefan Hajnoczi
2012-08-21 15:52 ` [Qemu-devel] [PATCH v2 1/3] net: asynchronous send/receive infrastructure " Stefan Hajnoczi
2012-08-21 16:39   ` ronnie sahlberg
2012-08-21 18:54     ` [Qemu-devel] Ping 1.2 PATCH "eventfd: making it thread safe" (was Re: [PATCH v2 1/3] net: asynchronous send/receive infrastructure for net/socket.c) Paolo Bonzini
2012-08-21 19:06       ` Anthony Liguori
2012-08-22 21:07         ` Paolo Bonzini
2012-08-22 21:25           ` Anthony Liguori
2012-08-22  9:24     ` [Qemu-devel] [PATCH v2 1/3] net: asynchronous send/receive infrastructure for net/socket.c Stefan Hajnoczi
2012-08-21 15:52 ` Stefan Hajnoczi [this message]
2012-08-21 15:52 ` [Qemu-devel] [PATCH v2 3/3] net: EAGAIN handling for net/socket.c TCP Stefan Hajnoczi
2012-08-29 15:35 ` [Qemu-devel] [PATCH v2 0/3] net: asynchronous send/receive for net/socket.c Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345564351-14693-3-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).