From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T41Dd-0007jG-SN for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T41Dc-0005KD-To for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:57 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:65320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T41Dc-0005K5-PN for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:56 -0400 Received: by yenm4 with SMTP id m4so399996yen.4 for ; Tue, 21 Aug 2012 20:02:56 -0700 (PDT) From: Liu Ping Fan Date: Wed, 22 Aug 2012 11:02:42 +0800 Message-Id: <1345604562-27289-1-git-send-email-qemulist@gmail.com> Subject: [Qemu-devel] [PATCH] qom: removal of link property need to release its target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Liu Ping Fan , Anthony Liguori From: Liu Ping Fan Currently, link property's target is only managed by object_set_link_property(). This will raise such issue that when the property is finalized, its target has no opportunity to release. Fix this issue by introduce object_finalize_link_property() Signed-off-by: Liu Ping Fan --- qom/object.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index a552be2..76b3d34 100644 --- a/qom/object.c +++ b/qom/object.c @@ -957,6 +957,16 @@ static void object_set_link_property(Object *obj, Visitor *v, void *opaque, } } +static void object_finalize_link_property(Object *obj, const char *name, + void *opaque) +{ + Object **child = opaque; + + if (*child != NULL) { + object_unref(*child); + } +} + void object_property_add_link(Object *obj, const char *name, const char *type, Object **child, Error **errp) @@ -968,7 +978,7 @@ void object_property_add_link(Object *obj, const char *name, object_property_add(obj, name, full_type, object_get_link_property, object_set_link_property, - NULL, child, errp); + object_finalize_link_property, child, errp); g_free(full_type); } -- 1.7.4.4