* [Qemu-devel] [PATCH] xen-all.c: fix multiply issue for int and uint types
@ 2012-08-22 6:55 Dongxiao Xu
2012-08-22 10:12 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Dongxiao Xu @ 2012-08-22 6:55 UTC (permalink / raw)
To: qemu-devel; +Cc: stefano.stabellini
If the two multiply operands are int and uint types separately,
the int type will be transformed to uint firstly, which is not the
intent in our code piece. The fix is to add (int64_t) transform
for the uint type before the multiply.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
---
xen-all.c | 24 ++++++++++++++++--------
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/xen-all.c b/xen-all.c
index 61def2e..f76b051 100644
--- a/xen-all.c
+++ b/xen-all.c
@@ -712,7 +712,8 @@ static void cpu_ioreq_pio(ioreq_t *req)
for (i = 0; i < req->count; i++) {
tmp = do_inp(req->addr, req->size);
- cpu_physical_memory_write(req->data + (sign * i * req->size),
+ cpu_physical_memory_write(
+ req->data + (sign * i * (int64_t)req->size),
(uint8_t *) &tmp, req->size);
}
}
@@ -723,7 +724,8 @@ static void cpu_ioreq_pio(ioreq_t *req)
for (i = 0; i < req->count; i++) {
uint32_t tmp = 0;
- cpu_physical_memory_read(req->data + (sign * i * req->size),
+ cpu_physical_memory_read(
+ req->data + (sign * i * (int64_t)req->size),
(uint8_t*) &tmp, req->size);
do_outp(req->addr, req->size, tmp);
}
@@ -740,12 +742,14 @@ static void cpu_ioreq_move(ioreq_t *req)
if (!req->data_is_ptr) {
if (req->dir == IOREQ_READ) {
for (i = 0; i < req->count; i++) {
- cpu_physical_memory_read(req->addr + (sign * i * req->size),
+ cpu_physical_memory_read(
+ req->addr + (sign * i * (int64_t)req->size),
(uint8_t *) &req->data, req->size);
}
} else if (req->dir == IOREQ_WRITE) {
for (i = 0; i < req->count; i++) {
- cpu_physical_memory_write(req->addr + (sign * i * req->size),
+ cpu_physical_memory_write(
+ req->addr + (sign * i * (int64_t)req->size),
(uint8_t *) &req->data, req->size);
}
}
@@ -754,16 +758,20 @@ static void cpu_ioreq_move(ioreq_t *req)
if (req->dir == IOREQ_READ) {
for (i = 0; i < req->count; i++) {
- cpu_physical_memory_read(req->addr + (sign * i * req->size),
+ cpu_physical_memory_read(
+ req->addr + (sign * i * (int64_t)req->size),
(uint8_t*) &tmp, req->size);
- cpu_physical_memory_write(req->data + (sign * i * req->size),
+ cpu_physical_memory_write(
+ req->data + (sign * i * (int64_t)req->size),
(uint8_t*) &tmp, req->size);
}
} else if (req->dir == IOREQ_WRITE) {
for (i = 0; i < req->count; i++) {
- cpu_physical_memory_read(req->data + (sign * i * req->size),
+ cpu_physical_memory_read(
+ req->data + (sign * i * (int64_t)req->size),
(uint8_t*) &tmp, req->size);
- cpu_physical_memory_write(req->addr + (sign * i * req->size),
+ cpu_physical_memory_write(
+ req->addr + (sign * i * (int64_t)req->size),
(uint8_t*) &tmp, req->size);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] xen-all.c: fix multiply issue for int and uint types
2012-08-22 6:55 [Qemu-devel] [PATCH] xen-all.c: fix multiply issue for int and uint types Dongxiao Xu
@ 2012-08-22 10:12 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2012-08-22 10:12 UTC (permalink / raw)
To: Dongxiao Xu; +Cc: qemu-devel@nongnu.org, Stefano Stabellini
On Wed, 22 Aug 2012, Dongxiao Xu wrote:
> If the two multiply operands are int and uint types separately,
> the int type will be transformed to uint firstly, which is not the
> intent in our code piece. The fix is to add (int64_t) transform
> for the uint type before the multiply.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> xen-all.c | 24 ++++++++++++++++--------
> 1 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/xen-all.c b/xen-all.c
> index 61def2e..f76b051 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -712,7 +712,8 @@ static void cpu_ioreq_pio(ioreq_t *req)
>
> for (i = 0; i < req->count; i++) {
> tmp = do_inp(req->addr, req->size);
> - cpu_physical_memory_write(req->data + (sign * i * req->size),
> + cpu_physical_memory_write(
> + req->data + (sign * i * (int64_t)req->size),
> (uint8_t *) &tmp, req->size);
> }
> }
> @@ -723,7 +724,8 @@ static void cpu_ioreq_pio(ioreq_t *req)
> for (i = 0; i < req->count; i++) {
> uint32_t tmp = 0;
>
> - cpu_physical_memory_read(req->data + (sign * i * req->size),
> + cpu_physical_memory_read(
> + req->data + (sign * i * (int64_t)req->size),
> (uint8_t*) &tmp, req->size);
> do_outp(req->addr, req->size, tmp);
> }
> @@ -740,12 +742,14 @@ static void cpu_ioreq_move(ioreq_t *req)
> if (!req->data_is_ptr) {
> if (req->dir == IOREQ_READ) {
> for (i = 0; i < req->count; i++) {
> - cpu_physical_memory_read(req->addr + (sign * i * req->size),
> + cpu_physical_memory_read(
> + req->addr + (sign * i * (int64_t)req->size),
> (uint8_t *) &req->data, req->size);
> }
> } else if (req->dir == IOREQ_WRITE) {
> for (i = 0; i < req->count; i++) {
> - cpu_physical_memory_write(req->addr + (sign * i * req->size),
> + cpu_physical_memory_write(
> + req->addr + (sign * i * (int64_t)req->size),
> (uint8_t *) &req->data, req->size);
> }
> }
> @@ -754,16 +758,20 @@ static void cpu_ioreq_move(ioreq_t *req)
>
> if (req->dir == IOREQ_READ) {
> for (i = 0; i < req->count; i++) {
> - cpu_physical_memory_read(req->addr + (sign * i * req->size),
> + cpu_physical_memory_read(
> + req->addr + (sign * i * (int64_t)req->size),
> (uint8_t*) &tmp, req->size);
> - cpu_physical_memory_write(req->data + (sign * i * req->size),
> + cpu_physical_memory_write(
> + req->data + (sign * i * (int64_t)req->size),
> (uint8_t*) &tmp, req->size);
> }
> } else if (req->dir == IOREQ_WRITE) {
> for (i = 0; i < req->count; i++) {
> - cpu_physical_memory_read(req->data + (sign * i * req->size),
> + cpu_physical_memory_read(
> + req->data + (sign * i * (int64_t)req->size),
> (uint8_t*) &tmp, req->size);
> - cpu_physical_memory_write(req->addr + (sign * i * req->size),
> + cpu_physical_memory_write(
> + req->addr + (sign * i * (int64_t)req->size),
> (uint8_t*) &tmp, req->size);
> }
> }
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-22 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 6:55 [Qemu-devel] [PATCH] xen-all.c: fix multiply issue for int and uint types Dongxiao Xu
2012-08-22 10:12 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).